Subscribe/Unsubscribe functionality should work for non ajax.

[hailwood]

As the issue title says currently they expect you to use ajax so literally return 1 or false (k. consistency right?).

Anyway I don't see why the subscribe/unsubscribe methods in the forum are setup to only be callable via ajax;
https://github.com/silverstripe/silverstripe-forum/blob/master/code/pagetypes/Forum.php#L637

yet the other methods are setup to support either Ajax or standard submissions?
https://github.com/silverstripe/silverstripe-forum/blob/master/code/pagetypes/Forum.php#L757

I'm open to do a pull request to fix this; However I am aware this could potentially break and sites that are not sending the correct headers to identify that it is an ajax request?

(should we worry about breaking sites that are doing things wrong?).

Would this pull request be accepted or do we see any other options or issues?

[dhensby]

I'm happy to take a change that makes these methods more flexible. If users are relying on die('1'); then they need more help than we can provide them ;)

It's pretty hard to make an ajax request and not send the right headers because the browsers do it for you.

[hailwood]

Thanks for the merge @dhensby any chance of a release now ;)