Skip to content

Commit 5beeb79

Browse files
committed
refactor(#1782): trim the pre-review skip-signal comment
Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
1 parent 8378800 commit 5beeb79

2 files changed

Lines changed: 4 additions & 12 deletions

File tree

‎scripts/pre-review.sh‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,8 @@
1414
# PRIOR_REVIEW_FILE — prior sticky review body; rewritten to validated JSON
1515
# PRIOR_REVIEW_PROVENANCE — authenticated provenance for the prior review
1616
#
17-
# Skip signalling uses the pre-script output protocol
18-
# (fullsend docs/normative/prescript-output/v1, fullsend-ai/fullsend#4718):
19-
# when the PR is closed/merged or its author is in REVIEW_SKIP_AUTHORS, this
20-
# script writes skipped=true to the file named by FULLSEND_PRESCRIPT_OUTPUT
21-
# and fullsend run stops before creating the sandbox. Under a CLI that
22-
# predates the protocol the variable is unset and the write is skipped.
17+
# A closed/merged PR or a REVIEW_SKIP_AUTHORS author writes skipped=true via
18+
# the pre-script output protocol, so fullsend run stops before the sandbox.
2319
set -euo pipefail
2420

2521
: "${PR_URL:?PR_URL must be set}"

‎scripts/pre-review.src.sh‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,8 @@
1313
# PRIOR_REVIEW_FILE — prior sticky review body; rewritten to validated JSON
1414
# PRIOR_REVIEW_PROVENANCE — authenticated provenance for the prior review
1515
#
16-
# Skip signalling uses the pre-script output protocol
17-
# (fullsend docs/normative/prescript-output/v1, fullsend-ai/fullsend#4718):
18-
# when the PR is closed/merged or its author is in REVIEW_SKIP_AUTHORS, this
19-
# script writes skipped=true to the file named by FULLSEND_PRESCRIPT_OUTPUT
20-
# and fullsend run stops before creating the sandbox. Under a CLI that
21-
# predates the protocol the variable is unset and the write is skipped.
16+
# A closed/merged PR or a REVIEW_SKIP_AUTHORS author writes skipped=true via
17+
# the pre-script output protocol, so fullsend run stops before the sandbox.
2218
set -euo pipefail
2319

2420
: "${PR_URL:?PR_URL must be set}"

0 commit comments

Comments
 (0)