Repository navigation
test(#1784): assert the closed-PR review skip stops the stage - #1785
Conversation
The reject scenario's second /fs-review round only checked that the review workflow succeeded and posted the "Review skipped" comment. Both hold whether or not the agent ran, so the scenario could not prove that pre-review stopped the stage (fixed in #1783). Bump github.com/fullsend-ai/fullsend to main 3ea9dd1b8 (fullsend-ai/fullsend#8793, for fullsend-ai/fullsend#8792), which adds the step "the harness <agent> run was skipped by its pre-script". It reads the run's host telemetry for fullsend.prescript.skipped=true and requires no agent output. Add it after the second round's workflow step. The old pin's go.sum entries are replaced, matching previous bumps; fullsend's go.mod hash is unchanged. Verification: the behaviour package vets and compiles against the new pin with the CI-style -modfile replace setup, and the new line matches the registered step regex. harness/triggertest passes. Live behaviour scenarios could not run in the sandbox. make cannot run here (sandbox blocks /bin/sh); running the script-test commands directly gives the same 15 environment-only failures on main and on this branch. skillsaw --strict passed. pre-commit could not fetch hook repos; pre-commit-hooks v6.0.0 checks and lint-release-cases run directly passed, and scan-secrets (gitleaks) passed. Closes #1784 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
/fs-fix-stop |
|
Fix agent disabled for this PR. Remove the |
|
🤖 Finished Review · ✅ Success · Started 10:14 PM UTC · Completed 10:21 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.97 |
|
<!-- fullsend:risk-assessment --> DetailsSmall, tightly scoped 3-file PR aligning with issue requirements, with risk elevated to moderate due to dependency updates in go.mod and go.sum alongside recent churn on those manifests. |
|
Looks good to me |
waynesun09
left a comment
There was a problem hiding this comment.
Approving at 7171358: fullsend bump to include #8793; behaviour run 40137590399 passed 11/11 with the reject scenario now proving the closed-PR review skip stops the stage; bot approved, no threads.
Summary
Changes in this repository:
behaviour/features/review/post-review-outcomes.feature: in "A rejecting review closes the pull request", the second/fs-reviewround now addsAnd the harness "review" run was skipped by its pre-scriptright after the workflow step.go.mod/go.sum: bumpgithub.com/fullsend-ai/fullsendfrom6d925afefto fullsendmain3ea9dd1b8(v0.50.1-0.20261024212938-3ea9dd1b82e4). That version adds the step. The old pin'sgo.sumentries are replaced, matching previous bumps. fullsend'sgo.modhash is unchanged.Why
Before this change, the second round checked only that the review workflow succeeded and that the "Review skipped" comment was posted. Both pass even if the agent ran anyway. The new step downloads the
fullsend-reviewartifact for that run. It requiresfullsend.prescript.skipped=trueon the rootrunspan in the host telemetry, and it requires that there is noagent-result.jsonorbehaviour-results.json. So it proves pre-review stopped the stage before the sandbox was created.Context
3ea9dd1b8, currently fullsendmainHEAD): add the step.Testing
-tags behaviour) vets and compiles against the new pin, using the same-modfile+ localreplacesetup asbehaviour-tests.yml.^the harness "([^"]+)" run was skipped by its pre-script$and capturesreview.harness/triggertestpasses against the new pin. It reads the rootgo.modpin's fixtures.make testcould not run throughmake(the sandbox blocks/bin/sh). I ran everyscript-testcommand directly: 31 pass and the same 15 environment-only failures appear onmainand on this branch.skillsaw --strict(themake lintcommand) passed.pre-commitcould not fetch hook repos. I ran the matchingpre-commit-hooksv6.0.0 checks andlint-release-casesdirectly and they passed.scan-secrets(gitleaks) passed.behaviourgreen with the reject scenario passing, not skipped, plus the job duration) has to be checked in CI.🤖 Generated with Claude Code
Closes #1784
Post-script verification
agent/1784-prove-review-skip)5543e099221f08daf2d1efdbe7cc62efa2c9252b..HEAD)