Skip to content

Commit 3ca0501

Browse files
ggallenclaude
andcommitted
docs: fix review findings round 2 for ADR 0043
- Rename gitlab-support.md title to "GitLab Support via Webhook Bridge" to differentiate from the superseded gitlab-implementation.md - Fix determine-stage dotenv propagation: add determine-stage to trigger-stage needs array so $STAGE variable is available - Fix label detection: use changes.labels.current[-1].name instead of .labels[-1].name to extract the just-added label from the webhook changes field - Note ADR 0028 supersession in ADR 0031 cross-reference - Note ADR 0028 supersession in agent-execution-environment.md references Signed-off-by: Greg Allen <gallen@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 4eb3859 commit 3ca0501

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

docs/ADRs/0031-reusable-workflows-for-action-installed-distribution.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ caller's perspective.
141141
inline, which partially mitigates this.
142142
- **GitHub-specific mechanism:** `workflow_call` and `secrets:` passthrough are
143143
GitHub Actions primitives with no direct equivalent in other CI systems.
144-
Multi-forge support ([ADR 0028](0028-gitlab-support.md)) will need its own
144+
Multi-forge support ([ADR 0043](0043-gitlab-support-via-webhook-bridge.md), supersedes ADR 0028) will need its own
145145
distribution mechanism (e.g., GitLab CI/CD Components or `include:`)
146146
independent of this ADR.
147147
- **Scaffold output changes:** `fullsend admin install` will emit thin callers

docs/plans/agent-execution-environment.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -922,7 +922,7 @@ spec:
922922
- [ADR-0036: Agent Execution Sandbox Architecture](../ADRs/0036-agent-execution-sandbox.md)
923923
- [ADR-0017: Credential Isolation for Sandboxed Agents](../ADRs/0017-credential-isolation-for-sandboxed-agents.md)
924924
- [ADR-0025: Provider Credential Delivery](../ADRs/0025-provider-credential-delivery-for-sandboxed-agents.md)
925-
- [ADR-0028: GitLab Support Architecture](../ADRs/0028-gitlab-support.md)
925+
- [ADR-0028: GitLab Support Architecture](../ADRs/0028-gitlab-support.md) (superseded by [ADR-0043](../ADRs/0043-gitlab-support-via-webhook-bridge.md))
926926
- [agent-infrastructure.md](../problems/agent-infrastructure.md): Infrastructure layer exploration
927927
- [OpenShell Documentation](https://docs.nvidia.com/openshell/)
928928
- [Sigstore Cosign](https://docs.sigstore.dev/cosign/overview/)

docs/problems/gitlab-support.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# GitLab Support Implementation Details
1+
# GitLab Support via Webhook Bridge
22

33
This document contains implementation details for GitLab support in fullsend. For the architectural decision and rationale, see [ADR 0043](../ADRs/0043-gitlab-support-via-webhook-bridge.md).
44

@@ -589,7 +589,7 @@ determine-stage:
589589
case "$ACTION" in
590590
open|update) STAGE="triage" ;;
591591
labeled)
592-
LABEL=$(echo "$PAYLOAD" | jq -r '.labels[-1].name // ""')
592+
LABEL=$(echo "$PAYLOAD" | jq -r '.changes.labels.current[-1].name // ""')
593593
case "$LABEL" in
594594
ready-to-code) STAGE="code" ;;
595595
ready-for-review) STAGE="review" ;;
@@ -672,7 +672,7 @@ generate-child-config:
672672
673673
trigger-stage:
674674
stage: dispatch
675-
needs: [generate-child-config]
675+
needs: [determine-stage, generate-child-config]
676676
rules:
677677
- if: $CI_COMMIT_REF_PROTECTED == "true" && $CI_PIPELINE_SOURCE == "trigger" && $STAGE
678678
trigger:

0 commit comments

Comments
 (0)