Commit 542ab8c
fullsend-code
fix(#1839): add technical doc accuracy to correctness sub-agent
The correctness sub-agent was declaring "zero correctness surface
area" on documentation-only PRs, even when those documents
contained implementation plans with verifiable technical claims
(algorithm descriptions, pseudocode, CLI flag semantics, API
behavior claims). Human reviewers on PR #1804 found 9 confirmed
technical accuracy issues that the bot missed.
Changes:
- Updated the correctness sub-agent definition to own technical
accuracy in implementation plans and design documents, with
specific evaluation guidance for algorithm logic, API/library
behavior claims, design document alignment, internal
consistency, and edge case correctness.
- Updated SKILL.md section 3b to classify docs/plans/ files and
technical documentation as having correctness surface area,
ensuring the correctness sub-agent is dispatched for such PRs.
- Added an implementation plan example to the dispatch table.
Note: make lint could not run (sandbox Go toolchain permission
error unrelated to these markdown-only changes). Pre-commit
encountered the same infrastructure error (exit code 3). The
post-script runs authoritative pre-commit on the runner.
Closes #1839
Signed-off-by: fullsend-code <fullsend-code@users.noreply.github.com>1 parent 1088f9b commit 542ab8c
2 files changed
Lines changed: 35 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
215 | 219 | | |
216 | 220 | | |
217 | 221 | | |
| |||
249 | 253 | | |
250 | 254 | | |
251 | 255 | | |
| 256 | + | |
252 | 257 | | |
253 | 258 | | |
254 | 259 | | |
| |||
Lines changed: 30 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
0 commit comments