Skip to content

Commit 972ce7f

Browse files
authored
Merge pull request #1807 from fullsend-ai/agent/852-add-consumer-completeness-check
fix(#852): add consumer-completeness check to code-review Correctness dimension
2 parents de4ce71 + 15dc4bb commit 972ce7f

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

  • internal/scaffold/fullsend-repo/skills/code-review

internal/scaffold/fullsend-repo/skills/code-review/SKILL.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,11 @@ dimension carry over to another — each requires its own scrutiny.
6666
external API (GitHub, cloud providers, etc.), verify the API accepts
6767
the new values for every code path that calls the function. Different
6868
API operations often have different required fields.
69+
- Consumer completeness: if the change adds new values to an enum,
70+
dispatch table, JSON schema enum, or case/switch structure, identify
71+
all code paths that consume or branch on that type (including scripts,
72+
configs, and files not in the diff) and verify each handles the new
73+
value. A new variant with no downstream handler is a logic error.
6974
- Test adequacy: are the right behaviors tested?
7075
- Do the tests actually constrain the code's behavior, or do they
7176
merely assert it runs?

0 commit comments

Comments
 (0)