Repository navigation
Commit e75bc41
committed
test(profiles): pin the egress binary each runtime needs on its profile
The claude.exe gap (#6971) was a class of failure, not a one-off: the
gateway's OPA matches a profile's binaries: glob against the
kernel-resolved exe of the process that opens the connection, so every
runtime has to name the file that actually runs, and a runtime pin bump
or a new runtime can silently break that. Cover the other runtimes the
same way:
- codex: bin/codex.js spawns vendor/<triple>/bin/codex (verified with
npm pack --dry-run on the 0.152.1 pin), matched by the **/codex the
OpenAI profile already carries.
- pi: an npm package executed by node, matched by **/node.
- opencode: follows the claude.exe pattern (opencode-ai ships a stub
bin/opencode.exe that postinstall replaces with the platform binary,
opencode-linux-x64/bin/opencode). The runtime is still a stub and not
in the sandbox image, so nothing is added to the profiles; the
mapping is pre-declared so the test fails the moment opencode joins
config.ValidRuntimes until both inference profiles allow
**/opencode and **/opencode.exe.
TestScaffoldProfilesAllowRuntimeBinaries walks config.ValidRuntimes and
requires each selectable runtime to have a declared mapping whose globs
are present in the scaffold profiles it uses; the runtime matrix in
docs/contributing/runtime-implementation.md gains an "egress binary
identity" row with the same facts and the verification recipe.
Refs #6971
Assisted-by: Claude (code, review), Grok (review)
Signed-off-by: Wayne Sun <gsun@redhat.com>1 parent 089e0ef commit e75bc41
3 files changed
Lines changed: 127 additions & 0 deletions
File tree
- docs/contributing
- internal
- cli
- runtime
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
37 | 42 | | |
38 | 43 | | |
39 | 44 | | |
| |||
269 | 274 | | |
270 | 275 | | |
271 | 276 | | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
272 | 293 | | |
273 | 294 | | |
274 | 295 | | |
| |||
916 | 937 | | |
917 | 938 | | |
918 | 939 | | |
| 940 | + | |
919 | 941 | | |
920 | 942 | | |
921 | 943 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
17 | 26 | | |
18 | 27 | | |
19 | 28 | | |
| |||
0 commit comments