Merge pull request #1180 from fullsend-ai/fullsend/code/issue-1142

fix(#1142): change DefaultAppSet from "fullsend" to "fullsend-ai"

Author: waynesun09

docs/ADRs/0033-per-repo-installation-mode.md

@@ -217,7 +217,7 @@ Per-repo maps to these profiles:
 | **Self-managed** | Per-repo user deploys own mint + own Apps | `fullsend admin install owner/repo --mint-project=my-proj` creates everything |
 
 **SaaS profile (default)**: The simplest path. Shared public Apps
-(`fullsend-triage`, `fullsend-coder`, `fullsend-review`) are pre-created
+(`fullsend-ai-triage`, `fullsend-ai-coder`, `fullsend-ai-review`) are pre-created
 by the platform operator and installed on the per-repo user's repo (requires
 org admin approval). The `mint-token` composite action exchanges a GitHub
 OIDC token for a scoped installation token — no PEMs, client IDs, or App
@@ -263,7 +263,7 @@ Shared flags (valid for both per-org and per-repo):
 - `--public` — create public unlisted GitHub Apps (for multi-org)
 - `--mint-provider` — token mint provider backend (default: `gcf`)
 - `--mint-source-dir` — path to mint function source directory
-- `--app-set` — app set name prefix for GitHub Apps (default: `fullsend`)
+- `--app-set` — app set name prefix for GitHub Apps (default: `fullsend-ai`)
 
 Per-org-only flags (`--vendor-fullsend-binary`, `--enroll-all`, `--enroll-none`) are rejected when an `owner/repo` argument is given. All other flags are shared between per-org and per-repo modes — per-repo can create GitHub Apps, deploy a mint, and manage public apps when existing infrastructure is not found.
 

docs/guides/admin/installation.md

@@ -73,7 +73,7 @@ The installer automatically provisions [Workload Identity Federation (WIF)](http
 | `--mint-provider` | `gcf` | Token mint provider backend |
 | `--mint-source-dir` | `internal/mint/` | Path to mint function source directory. When the path does not exist (e.g., running from a downloaded binary), the embedded source baked into the binary is used automatically |
 | `--public` | `false` | Create public unlisted GitHub Apps (for multi-org) |
-| `--app-set` | `fullsend` | App set name prefix for GitHub Apps (see [Custom app sets](#custom-app-sets)) |
+| `--app-set` | `fullsend-ai` | App set name prefix for GitHub Apps (see [Custom app sets](#custom-app-sets)) |
 | `--skip-app-setup` | `false` | Skip GitHub App creation (reuse existing apps) |
 | `--skip-mint-deploy` | `false` | Skip Cloud Function deployment, reuse existing mint URL |
 | `--skip-mint-check` | `false` | Skip mint validation, GCP provisioning, and app setup; requires `--mint-url` |
@@ -222,7 +222,7 @@ The uninstall preflight will prompt you to add the `delete_repo` scope if it is
 | Flag | Default | Description |
 |------|---------|-------------|
 | `--yolo` | `false` | Skip the confirmation prompt |
-| `--app-set` | `fullsend` | App set name prefix for GitHub Apps (used for fallback slug generation when config is unavailable) |
+| `--app-set` | `fullsend-ai` | App set name prefix for GitHub Apps (used for fallback slug generation when config is unavailable) |
 
 ---
 
@@ -287,7 +287,7 @@ Per-repo accepts all `admin install` flags except `--vendor-fullsend-binary`, `-
 
 ## Custom app sets
 
-By default, the installer creates GitHub Apps with the `fullsend` prefix (e.g., `fullsend-fullsend`, `fullsend-coder`, `fullsend-review`). Organizations that need their own set of apps — for example, to use org-specific permissions or to register multiple app sets on the same mint — can pass `--app-set` to override the prefix.
+By default, the installer creates GitHub Apps with the `fullsend-ai` prefix (e.g., `fullsend-ai-fullsend`, `fullsend-ai-coder`, `fullsend-ai-review`). Organizations that need their own set of apps — for example, to use org-specific permissions or to register multiple app sets on the same mint — can pass `--app-set` to override the prefix.
 
 ### Creating a custom app set
 
@@ -313,6 +313,8 @@ fullsend admin install "$NEW_ORG" \
 
 The installer detects that the public apps are already installed in the org (matched by app ID from the mint's `ROLE_APP_IDS`), copies PEM secrets to the new org's scoped key, and skips app creation. The `--app-set` value ensures convention-based slug lookups match the existing apps.
 
+> **Migration note:** Prior to this change, the default app set was `fullsend`, producing slugs like `fullsend-coder`. The default is now `fullsend-ai`, producing `fullsend-ai-coder`. Existing installations that used the old default should pass `--app-set fullsend` explicitly to continue matching their existing GitHub App slugs, or re-install with the new default.
+
 ### Uninstalling a custom app set
 
 When uninstalling an org that used a custom app set, pass the same `--app-set` value so the CLI generates the correct fallback slugs if the config repo is unavailable:

docs/guides/dev/cli-internals.md

@@ -74,7 +74,7 @@ Both per-org and per-repo modes share the same core pipeline. The code follows t
 │  │ Phase 2: App setup (shared: runAppSetup)                   │ │
 │  │                                                            │ │
 │  │  For each role in --agents:                                │ │
-│  │    - Create/reuse GitHub App ({org}-{role} or --app-set)   │ │
+│  │    - Create/reuse GitHub App ({appSet}-{role} via --app-set)│ │
 │  │    - Download PEM key from App creation flow               │ │
 │  │    - Store PEM in GCP Secret Manager                       │ │
 │  │    - Record App ID + Client ID                             │ │

e2e/admin/cleanup.go

@@ -52,7 +52,7 @@ func cleanupStaleResources(ctx context.Context, client forge.Client, page playwr
 			t.Logf("[cleanup] App %s not found or could not delete: %v", slug, delErr)
 		}
 
-		newSlug := appsetup.AppSlug(appsetup.DefaultAppSet, role) // current convention: fullsend-triage, etc.
+		newSlug := appsetup.AppSlug(appsetup.DefaultAppSet, role) // current convention: fullsend-ai-triage, etc.
 		if newSlug != slug {
 			t.Logf("[cleanup] Attempting to delete app %s (if it exists)", newSlug)
 			if delErr := deleteAppViaPlaywright(page, newSlug, t.Logf, screenshotDir); delErr != nil {
@@ -77,7 +77,7 @@ func cleanupStaleResources(ctx context.Context, client forge.Client, page playwr
 		for _, inst := range installations {
 			// Safe: testOrg is a dedicated E2E org with no production apps.
 			isStale := strings.HasPrefix(inst.AppSlug, testOrg+"-") || // v6: halfsend-*
-				strings.HasPrefix(inst.AppSlug, appsetup.DefaultAppSet+"-") || // current: fullsend-*
+				strings.HasPrefix(inst.AppSlug, appsetup.DefaultAppSet+"-") || // current: fullsend-ai-*
 				strings.HasPrefix(inst.AppSlug, "fullsend-") // legacy: fullsend-triage, fullsend-halfsend-*, etc.
 			if isStale {
 				t.Logf("[cleanup] Deleting stale installed app: %s", inst.AppSlug)

internal/appsetup/appsetup.go

@@ -868,9 +868,11 @@ func (s *Setup) ensureInstalled(ctx context.Context, org, slug string) error {
 }
 
 // DefaultAppSet is the default app set prefix for GitHub Apps.
-// Orgs that created apps under a different prefix (e.g., "fullsend-ai")
-// pass --app-set explicitly.
-const DefaultAppSet = "fullsend"
+// The official GitHub Apps maintained by the fullsend-ai organization use
+// the "fullsend-ai" prefix (fullsend-ai-fullsend, fullsend-ai-coder, etc.).
+// Orgs that created apps under a different prefix (e.g., "fullsend")
+// must pass --app-set explicitly.
+const DefaultAppSet = "fullsend-ai"
 
 // AppSlug returns the conventional app slug for a given app set and role.
 func AppSlug(appSet, role string) string {

internal/appsetup/appsetup_test.go

@@ -756,10 +756,10 @@ func TestSetup_CorrectPermissions_NoError(t *testing.T) {
 func TestSetup_DefaultAppSet(t *testing.T) {
 	client := &forge.FakeClient{
 		Installations: []forge.Installation{
-			{ID: 100, AppID: 10, AppSlug: "fullsend-coder"},
+			{ID: 100, AppID: 10, AppSlug: "fullsend-ai-coder"},
 		},
 		AppClientIDs: map[string]string{
-			"fullsend-coder": "Iv1.default123",
+			"fullsend-ai-coder": "Iv1.default123",
 		},
 	}
 	printer := ui.New(&discardWriter{})
@@ -769,7 +769,7 @@ func TestSetup_DefaultAppSet(t *testing.T) {
 
 	creds, err := s.Run(context.Background(), "myorg", "coder")
 	require.NoError(t, err)
-	assert.Equal(t, "fullsend-coder", creds.Slug)
+	assert.Equal(t, "fullsend-ai-coder", creds.Slug)
 	assert.Equal(t, "Iv1.default123", creds.ClientID)
 }
 

internal/cli/admin.go

@@ -530,7 +530,7 @@ Inference authentication:
 	cmd.Flags().BoolVar(&mintSkipDeploy, "skip-mint-deploy", false, "skip Cloud Function deployment, reuse existing mint URL")
 	cmd.Flags().BoolVar(&skipMintCheck, "skip-mint-check", false, "skip mint validation, GCP provisioning, and app setup; requires --mint-url")
 	cmd.Flags().BoolVar(&publicApps, "public", false, "create public (unlisted) GitHub Apps installable by other orgs")
-	cmd.Flags().StringVar(&appSet, "app-set", appsetup.DefaultAppSet, "app set name prefix for GitHub Apps (e.g., fullsend-ai creates fullsend-ai-fullsend, fullsend-ai-coder)")
+	cmd.Flags().StringVar(&appSet, "app-set", appsetup.DefaultAppSet, "app set name prefix for GitHub Apps (e.g., myorg creates myorg-fullsend, myorg-coder)")
 	// Shared flags.
 	cmd.Flags().StringVar(&mintURL, "mint-url", "", "token mint URL for OIDC token exchange")
 

internal/cli/admin_test.go

@@ -113,7 +113,7 @@ func TestInstallCmd_Flags(t *testing.T) {
 
 	appSetFlag := cmd.Flags().Lookup("app-set")
 	require.NotNil(t, appSetFlag, "expected --app-set flag")
-	assert.Equal(t, "fullsend", appSetFlag.DefValue)
+	assert.Equal(t, "fullsend-ai", appSetFlag.DefValue)
 }
 
 func TestInstallCmd_InvalidAppSet(t *testing.T) {
@@ -302,7 +302,7 @@ func TestUninstallCmd_Flags(t *testing.T) {
 
 	appSetFlag := cmd.Flags().Lookup("app-set")
 	require.NotNil(t, appSetFlag, "expected --app-set flag")
-	assert.Equal(t, "fullsend", appSetFlag.DefValue)
+	assert.Equal(t, "fullsend-ai", appSetFlag.DefValue)
 }
 
 func TestAnalyzeCmd_RequiresOrg(t *testing.T) {
@@ -1524,7 +1524,7 @@ func TestFilterSlugsByAppSet(t *testing.T) {
 			want:   map[string]string{},
 		},
 		{
-			name:   "default app-set does not match longer prefix",
+			name:   "shorter prefix does not match longer slug",
 			appSet: "fullsend",
 			slugs:  map[string]string{"coder": "fullsend-ai-coder"},
 			want:   map[string]string{},

internal/forge/github/types_test.go

@@ -114,19 +114,19 @@ func TestAgentAppConfig_UnknownRole(t *testing.T) {
 }
 
 func TestAgentAppConfig_CustomAppSet(t *testing.T) {
-	cfg := AgentAppConfig("myorg", "coder", "fullsend-ai")
-	assert.Equal(t, "fullsend-ai-coder", cfg.Name)
+	cfg := AgentAppConfig("myorg", "coder", "my-custom")
+	assert.Equal(t, "my-custom-coder", cfg.Name)
 
-	cfg = AgentAppConfig("myorg", "fullsend", "fullsend-ai")
-	assert.Equal(t, "fullsend-ai-fullsend", cfg.Name)
+	cfg = AgentAppConfig("myorg", "fullsend", "my-custom")
+	assert.Equal(t, "my-custom-fullsend", cfg.Name)
 }
 
 func TestAgentAppConfig_DefaultAppSet(t *testing.T) {
-	cfg := AgentAppConfig("myorg", "coder", "fullsend")
-	assert.Equal(t, "fullsend-coder", cfg.Name)
+	cfg := AgentAppConfig("myorg", "coder", "fullsend-ai")
+	assert.Equal(t, "fullsend-ai-coder", cfg.Name)
 
-	cfg = AgentAppConfig("myorg", "fullsend", "fullsend")
-	assert.Equal(t, "fullsend-fullsend", cfg.Name)
+	cfg = AgentAppConfig("myorg", "fullsend", "fullsend-ai")
+	assert.Equal(t, "fullsend-ai-fullsend", cfg.Name)
 }
 
 func TestAppConfig_RedirectURL_InJSON(t *testing.T) {