Skip to content

test(behaviour): add review dispatch trigger scenarios (bash routing) #2892

Description

@ifireball

What is missing

Behaviour tests cover triage dispatch triggers partially, but review has no behaviour scenarios that verify dispatch triggers fire the correct agent run on the current bash router in reusable-dispatch.yml.

We need this baseline before porting review's trigger logic to harness CEL expressions.

What should happen

One vertical PR adds Godog scenarios for review dispatch triggers:

  • Triggers: PR opened/synchronize, ready-for-review label, /fs-review
  • Uses bash route job only (no CEL, no harness-dispatch)
  • Agent runs via dummy runtime; assert outcome (e.g. behaviour-results.json or expected side effect)
  • Requires behaviour framework (PR #1982)

Merge criterion

make behaviour-test green with new review trigger scenarios.

Blocks

Port review to harness CEL trigger (#2898).

Related

Part of epic #2888. Does not block the custom-agent harness-dispatch issue (#2889).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    Status
    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions