Skip to content

Add AGENTS.md guidance that implementation plan docs are historical records #2948

Description

@fullsend-ai-retro

What happened

PR #2761 migrated the retro harness from runner_env to env.runner/env.sandbox per ADR 0055, deleting env/retro.env. The review agent on PR #2761 flagged 6 stale references to retro.env in docs/superpowers/plans/2026-05-04-retro-agent.md as a low-severity [stale-reference] finding. The retro agent picked up this finding and filed issue #2939. The triage agent confirmed it, labeling it ready-to-code and good first issue. The code agent attempted a fix but failed. An external contributor (sreedhards) volunteered, spent time understanding the issue, and opened PR #2946. Maintainer ralphbean then closed both the issue and PR as unnecessary — historical plan docs are point-in-time records and don't need updating. This cascaded across 4+ agent runs and wasted a contributor's time.

What could go better

AGENTS.md has explicit immutability guidance for ADRs (lines 94-102) but no equivalent for implementation plan docs under docs/superpowers/plans/. These plan docs follow a similar lifecycle: they are point-in-time records of how features were designed and built, and become historical once the work is complete. Without this context, three agents in the chain (review, retro, triage) all treated stale references in a plan doc as an actionable issue. Confidence is high — the maintainer explicitly stated that updating historical plans is unnecessary, and the pattern mirrors the existing ADR immutability rule. The AGENTS.md gap is the clear root cause: agents had no way to know plan docs are historical.

Proposed change

Add a new section to AGENTS.md after the ADR section (around line 103) titled Implementation plans with guidance analogous to the ADR immutability rule. Suggested content:

## Implementation plans

Implementation plans (`docs/superpowers/plans/`) are point-in-time records of how features were designed and built. Like ADRs, they are historical — do not update them to track subsequent codebase changes. Stale file paths, deleted environment variables, and outdated code references in completed plans are expected artifacts, not bugs.

**When reviewing PRs:** Do not flag stale references in plan docs as findings. A PR that deletes a file referenced in a plan doc does not need to update the plan.

**When triaging issues:** Reject issues that propose updating completed plan docs to match current code. These are unnecessary maintenance.

This parallels the ADR immutability pattern already established in AGENTS.md and directly addresses review, retro, and triage agent behavior for this class of file.

Validation criteria

  1. Grep AGENTS.md for 'Implementation plans' confirms the section exists.
  2. Over the next 5 PRs that delete or rename files referenced in plan docs, verify the review agent does not flag stale plan-doc references.
  3. If a retro agent files an issue about updating a plan doc, the triage agent rejects it rather than labeling it ready-to-code.
  4. No further contributor time is wasted on plan-doc update issues.

Generated by retro agent from #2939

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/retroRetro agentcomponent/docsUser-facing documentationfeatureFeature-category issue awaiting human prioritizationgood first issueGood for newcomerspriority/mediumNormal priority, plan for next cycleready-for-triageRetro-filed issue awaiting triage agenttriagedTriaged but awaiting human prioritizationtype/choreMaintenance and housekeeping tasks

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    Status
    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions