What happened
On PR #2453 (docs ADR for dispatch version-skew resolution), human reviewer waynesun09 flagged ADR number collisions as HIGH severity across three review rounds — the new ADR collided with numbers 0055, 0058, and 0061 in sequence as other PRs merged concurrently. The review agent ran 4+ substantive review cycles on PR #2453 and never detected the number collision at any severity. Issue #2856 was filed by the retro agent to address the severity calibration gap, and the code agent produced PR #2857 which adds explicit severity rules for ADR immutability violations and amendment scope. However, PR #2857 does not address ADR number collision detection — that class of issue remains undetected by the review agent.
What could go better
The intent-coherence sub-agent now has rules for ADR content modifications (immutability violations, amendment scope) but has no guidance for detecting ADR number collisions. The repo already has a renumber-adr skill as a pre-merge tool, but the review agent doesn't check for collisions during review. This means an entire category of HIGH-severity finding that humans consistently catch remains invisible to the review agent. Confidence is high — this is a clear gap evidenced by PR #2453's review history where the collision was flagged by humans but never by the bot across multiple review cycles.
Proposed change
Add an ADR number collision check to the intent-coherence sub-agent definition at internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md, within the existing ADR convention violations section. The check should: (1) when a PR adds a new ADR file, verify the chosen number doesn't conflict with any ADR already on the base branch, (2) flag collisions as HIGH severity under a new adr-number-collision category, (3) suggest the author run the renumber-adr skill to resolve. Register adr-number-collision in the orchestrator's dimension mapping table in internal/scaffold/fullsend-repo/skills/pr-review/SKILL.md alongside the existing adr-immutability-violation and adr-amendment-scope categories.
Validation criteria
On the next 3 PRs that add new ADR files, the review agent should detect any number collisions and rate them HIGH. Can be tested by creating a PR that deliberately reuses an existing ADR number (e.g., adding a new file named 0001-*.md) and verifying the review agent flags the collision at HIGH severity with the adr-number-collision category.
Generated by retro agent from #2857
What happened
On PR #2453 (docs ADR for dispatch version-skew resolution), human reviewer waynesun09 flagged ADR number collisions as HIGH severity across three review rounds — the new ADR collided with numbers 0055, 0058, and 0061 in sequence as other PRs merged concurrently. The review agent ran 4+ substantive review cycles on PR #2453 and never detected the number collision at any severity. Issue #2856 was filed by the retro agent to address the severity calibration gap, and the code agent produced PR #2857 which adds explicit severity rules for ADR immutability violations and amendment scope. However, PR #2857 does not address ADR number collision detection — that class of issue remains undetected by the review agent.
What could go better
The intent-coherence sub-agent now has rules for ADR content modifications (immutability violations, amendment scope) but has no guidance for detecting ADR number collisions. The repo already has a
renumber-adrskill as a pre-merge tool, but the review agent doesn't check for collisions during review. This means an entire category of HIGH-severity finding that humans consistently catch remains invisible to the review agent. Confidence is high — this is a clear gap evidenced by PR #2453's review history where the collision was flagged by humans but never by the bot across multiple review cycles.Proposed change
Add an ADR number collision check to the intent-coherence sub-agent definition at
internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md, within the existing ADR convention violations section. The check should: (1) when a PR adds a new ADR file, verify the chosen number doesn't conflict with any ADR already on the base branch, (2) flag collisions as HIGH severity under a newadr-number-collisioncategory, (3) suggest the author run therenumber-adrskill to resolve. Registeradr-number-collisionin the orchestrator's dimension mapping table ininternal/scaffold/fullsend-repo/skills/pr-review/SKILL.mdalongside the existingadr-immutability-violationandadr-amendment-scopecategories.Validation criteria
On the next 3 PRs that add new ADR files, the review agent should detect any number collisions and rate them HIGH. Can be tested by creating a PR that deliberately reuses an existing ADR number (e.g., adding a new file named 0001-*.md) and verifying the review agent flags the collision at HIGH severity with the
adr-number-collisioncategory.Generated by retro agent from #2857