[v3] Standardised authentication errors

[SamMatthewsIsACommonName]

Right now the authentication error objects returned sometimes have a 'name' property with what is essentially the error code, and sometimes a 'code' property. This makes switching over the error in a reducer quite complicated as they're not consistent e.g 'action.payload.name' vs 'action.payload.code'.
Also it seems as though firebase are moving towards descriptive text errors as the 'code' rather than the old numerical codes:
https://firebase.google.com/docs/reference/js/firebase.auth.Error
So getting these in line would be really good for reference purposes.
Cheers!

[SamMatthewsIsACommonName]

Code references here http://cocoadocs.org/docsets/FirebaseAuth/3.0.2/Constants/FIRAuthErrorCode.html

[davecoates]

This may help as a reference mapping to the error code strings used in the web API:

https://github.com/davecoates/rn-firebase-bridge/blob/master/ios/FirebaseBridgeAuth.swift

Unfortunately Android doesn't seem to use the full list of error codes so you are limited to a subset of those

[SamMatthewsIsACommonName]

Great thanks Dave!

On 8 Nov 2016, at 11:44, Dave Coates notifications@github.com wrote:

This may help as a reference mapping to the error code strings used in the web API:

https://github.com/davecoates/rn-firebase-bridge/blob/master/ios/FirebaseBridgeAuth.swift https://github.com/davecoates/rn-firebase-bridge/blob/master/ios/FirebaseBridgeAuth.swift
Unfortunately Android doesn't seem to use the full list of error codes so you are limited to a subset of those

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #86 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AUV0p8FMSXx9RxvCQbcvC8whd_Ur7J-gks5q76mygaJpZM4KhLX4.

[Salakar]

This is something @Ehesp and I want to sort on v3, we've already standardised a lot of the auth module to match the web api and can be seen on my fork or the v3 branch.

The plan is move these into the same format as web api, e.g. returning an error code of auth/disabled-user