Skip to content

Commit 3dad42b

Browse files
committed
add testfile tls/testcert.pem tls/testkey.pem
1 parent ede18a4 commit 3dad42b

24 files changed

+280
-399
lines changed

internal/certigo/lib/certs.go

-2
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ func GuessFormatForFile(filename string, format CertificateKeyFormat) (Certifica
162162

163163
// Heuristics for guessing -- best effort.
164164
magic := binary.BigEndian.Uint32(data)
165-
fmt.Printf(" magic 0x%0x\n", magic)
166165
if magic == 0xCECECECE || magic == 0xFEEDFEED {
167166
// JCEKS/JKS files always start with this prefix
168167
return CertKeyFormatJCEKS, nil
@@ -355,7 +354,6 @@ func readCertsFromStream(reader io.Reader, filename string, format CertificateKe
355354
x509Certs, err0 := x509.ParseCertificates(data)
356355
if err0 == nil {
357356
for _, cert := range x509Certs {
358-
fmt.Printf("cert cn: %v\n", cert.Issuer.CommonName)
359357
err := callback(encodeX509ToPEM(cert, headers), format)
360358
if err != nil {
361359
return err

internal/certigo/lib/certs_test.go

+12-14
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,12 @@ func TestClientTLSConfig(t *testing.T) {
88
derfmt := CertKeyFormatDER
99
pemfmt := CertKeyFormatPEM
1010
pfxfmt := CertKeyFormatPKCS12
11-
testTLSConfig(t, false, "tls/ca.crt", pemfmt, "tls/client.crt", pemfmt, "tls/client.key", pemfmt, "")
12-
testTLSConfig(t, false, "tls/ca.crt", pemfmt, "tls/client.der", derfmt, "tls/client.key", pemfmt, "")
13-
testTLSConfig(t, false, "tls/ca.crt", pemfmt, "tls/client.pfx", pfxfmt, "tls/client.key", pemfmt, "")
14-
testTLSConfig(t, false, "tls/ca.crt", pemfmt, "tls/client_pass.pfx", pfxfmt, "", pemfmt, "pfxpassword")
15-
testTLSConfig(t, false, "tls/ca.der", derfmt, "tls/client.pfx", pfxfmt, "", pemfmt, "")
16-
//testTLSConfig(t, false, "tls/ca.crt", pemfmt, "tls/client.crt", pemfmt, "tls/client.key.pass", pemfmt, "123456") // not support
17-
//testTLSConfig(t, false, "tls/ca.crt", pemfmt, "tls/client_pass.pfx", pfxfmt, "", pemfmt, "invalidpwd") // invalid
18-
//testTLSConfig(t, false, "tls/ca.crt", pemfmt, "tls/client.der", derfmt, "tls/client.key.der", derfmt, "") key can not be der
11+
testTLSConfig(t, false, "../../testing/tls/ca.crt", pemfmt, "../../testing/tls/client.crt", pemfmt, "../../testing/tls/client.key", pemfmt, "")
12+
testTLSConfig(t, false, "../../testing/tls/ca.crt", pemfmt, "../../testing/tls/client.der", derfmt, "../../testing/tls/client.key", pemfmt, "")
13+
testTLSConfig(t, false, "../../testing/tls/ca.crt", pemfmt, "../../testing/tls/client.pfx", pfxfmt, "../../testing/tls/client.key", pemfmt, "")
14+
testTLSConfig(t, false, "../../testing/tls/ca.crt", pemfmt, "../../testing/tls/client_pass.pfx", pfxfmt, "", pemfmt, "pfxpassword")
15+
testTLSConfig(t, false, "../../testing/tls/ca.der", derfmt, "../../testing/tls/client.pfx", pfxfmt, "", pemfmt, "")
16+
testTLSConfig(t, false, "../../testing/tls/ca.crt", pemfmt, "../../testing/tls/testcert.pem", pemfmt, "../../testing/tls/testkey.pem", pemfmt, "")
1917
}
2018

2119
func testTLSConfig(
@@ -40,12 +38,12 @@ func testTLSConfig(
4038
}
4139

4240
func TestGuessFormat(t *testing.T) {
43-
guessFormat(t, "tls/client.crt", CertKeyFormatPEM)
44-
guessFormat(t, "tls/client.cer", CertKeyFormatPEM)
45-
guessFormat(t, "tls/client.key", CertKeyFormatPEM)
46-
guessFormat(t, "tls/client.pfx", CertKeyFormatPKCS12)
47-
guessFormat(t, "tls/client.der", CertKeyFormatDER)
48-
forceFormat(t, "tls/client.guess", CertKeyFormatPEM, CertKeyFormatPEM)
41+
guessFormat(t, "../../testing/tls/client.crt", CertKeyFormatPEM)
42+
guessFormat(t, "../../testing/tls/client.cer", CertKeyFormatPEM)
43+
guessFormat(t, "../../testing/tls/client.key", CertKeyFormatPEM)
44+
guessFormat(t, "../../testing/tls/client.pfx", CertKeyFormatPKCS12)
45+
guessFormat(t, "../../testing/tls/client.der", CertKeyFormatDER)
46+
forceFormat(t, "../../testing/tls/client.guess", CertKeyFormatPEM, CertKeyFormatPEM)
4947
}
5048

5149
func guessFormat(t *testing.T, filename string, formatExpected CertificateKeyFormat) {

internal/certigo/lib/tls/ca.crl

-16
This file was deleted.

internal/certigo/lib/tls/ca.crt

-28
This file was deleted.

internal/certigo/lib/tls/ca.der

-1.22 KB
Binary file not shown.

internal/certigo/lib/tls/ca.key

-51
This file was deleted.

internal/certigo/lib/tls/client.cer

-101
This file was deleted.

internal/certigo/lib/tls/client.crt

-25
This file was deleted.

internal/certigo/lib/tls/client.csr

-16
This file was deleted.

internal/certigo/lib/tls/client.der

-1.05 KB
Binary file not shown.

0 commit comments

Comments
 (0)