Skip to content

Commit efbf86e

Browse files
authored
Merge pull request #65 from hamayokokuririn/fix/set-displayDelegate
Fix image-only and banner message repeatedly displaying after app restart
2 parents 9b61339 + a6db955 commit efbf86e

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

Sources/SwiftyInAppMessaging/Default/Banner/InAppDefaultBannerMessageHandler.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import Foundation
1111
import UIKit
1212

13-
struct InAppDefaultBannerMessageHandler: InAppBannerMessageHandler {
13+
class InAppDefaultBannerMessageHandler: InAppBannerMessageHandler {
1414
let messageForDisplay: InAppMessagingBannerDisplay
1515
weak private(set) var displayDelegate: InAppMessagingDisplayDelegate?
1616

@@ -21,6 +21,8 @@
2121
}
2222

2323
func displayMessage(with delegate: InAppMessagingDisplayDelegate) {
24+
self.displayDelegate = delegate
25+
2426
let bannerImage = try? UIImage(imageData: self.messageForDisplay.imageData)
2527

2628
let viewController = InAppDefaultBannerMessageViewController(

Sources/SwiftyInAppMessaging/Default/ImageOnly/InAppDefaultImageOnlyMessageHandler.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import Foundation
1010
import UIKit
1111

12-
struct InAppDefaultImageOnlyMessageHandler: InAppImageOnlyMessageHandler {
12+
class InAppDefaultImageOnlyMessageHandler: InAppImageOnlyMessageHandler {
1313
let messageForDisplay: InAppMessagingImageOnlyDisplay
1414
weak private(set) var displayDelegate: InAppMessagingDisplayDelegate?
1515

@@ -20,6 +20,8 @@
2020
}
2121

2222
func displayMessage(with delegate: InAppMessagingDisplayDelegate) throws {
23+
self.displayDelegate = delegate
24+
2325
let image = try UIImage(imageData: self.messageForDisplay.imageData)
2426
let viewController = InAppDefaultImageOnlyMessageViewController(
2527
image: image,

Tests/SwiftyInAppMessagingTests/Utilities/DisplayMessage.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
messageID: String = "",
1313
campaignName: String = "",
1414
renderAsTestMessage: Bool = false,
15-
messageType: FIRInAppMessagingDisplayMessageType,
16-
triggerType: FIRInAppMessagingDisplayTriggerType = .onAppForeground
15+
messageType: InAppMessagingDisplayMessageType,
16+
triggerType: InAppMessagingDisplayTriggerType = .onAppForeground
1717
) -> InAppMessagingDisplayMessage {
1818
switch messageType {
1919
case .modal:

Tests/SwiftyInAppMessagingTests/Utilities/Handler.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
func displayMessage(with delegate: InAppMessagingDisplayDelegate) throws {
1717
}
1818

19-
func messageDismissed(dismissType: FIRInAppMessagingDismissType) {
19+
func messageDismissed(dismissType: InAppMessagingDismissType) {
2020
}
2121

2222
func messageClicked(with action: InAppMessagingAction) {

0 commit comments

Comments
 (0)