From 6a079fc1553fc375bbdcd959784a19b021fcb543 Mon Sep 17 00:00:00 2001 From: Fumito Ito Date: Thu, 6 Nov 2025 11:21:28 +0900 Subject: [PATCH] Remove excessive `UIApplication.shared.open` calls. --- .../InAppDefaultBannerMessageViewControlller.swift | 2 -- .../Card/InAppDefaultCardMessageViewController.swift | 10 ---------- .../InAppDefaultImageOnlyMessageViewController.swift | 4 ---- .../Modal/InAppDefaultModalMessageViewController.swift | 5 ----- 4 files changed, 21 deletions(-) diff --git a/Sources/SwiftyInAppMessaging/Default/Banner/InAppDefaultBannerMessageViewControlller.swift b/Sources/SwiftyInAppMessaging/Default/Banner/InAppDefaultBannerMessageViewControlller.swift index edb1e89..eaafa06 100644 --- a/Sources/SwiftyInAppMessaging/Default/Banner/InAppDefaultBannerMessageViewControlller.swift +++ b/Sources/SwiftyInAppMessaging/Default/Banner/InAppDefaultBannerMessageViewControlller.swift @@ -134,8 +134,6 @@ actionText: self?.title, actionURL: self?.actionURL) self?.eventDetector.messageClicked(with: action) }) - - UIApplication.shared.open(url, options: [:], completionHandler: nil) } } diff --git a/Sources/SwiftyInAppMessaging/Default/Card/InAppDefaultCardMessageViewController.swift b/Sources/SwiftyInAppMessaging/Default/Card/InAppDefaultCardMessageViewController.swift index dc88cef..bb6c0f8 100644 --- a/Sources/SwiftyInAppMessaging/Default/Card/InAppDefaultCardMessageViewController.swift +++ b/Sources/SwiftyInAppMessaging/Default/Card/InAppDefaultCardMessageViewController.swift @@ -175,22 +175,12 @@ extension InAppDefaultCardMessageViewController: InAppDefaultCardMessageViewDelegate { public func primaryActionButtonDidTap() { - - if let actionURL = self.primaryActionURL, UIApplication.shared.canOpenURL(actionURL) { - UIApplication.shared.open(actionURL, options: [:], completionHandler: nil) - } - let action = InAppMessagingAction( actionText: self.primaryActionButtonText, actionURL: self.primaryActionURL) eventDetector.messageClicked(with: action) } public func secondaryActionButtonDidTap() { - - if let actionURL = self.secondaryActionURL, UIApplication.shared.canOpenURL(actionURL) { - UIApplication.shared.open(actionURL, options: [:], completionHandler: nil) - } - let action = InAppMessagingAction( actionText: self.secondaryActionButtonText, actionURL: self.secondaryActionURL) eventDetector.messageClicked(with: action) diff --git a/Sources/SwiftyInAppMessaging/Default/ImageOnly/InAppDefaultImageOnlyMessageViewController.swift b/Sources/SwiftyInAppMessaging/Default/ImageOnly/InAppDefaultImageOnlyMessageViewController.swift index cea20bd..6f43863 100644 --- a/Sources/SwiftyInAppMessaging/Default/ImageOnly/InAppDefaultImageOnlyMessageViewController.swift +++ b/Sources/SwiftyInAppMessaging/Default/ImageOnly/InAppDefaultImageOnlyMessageViewController.swift @@ -140,10 +140,6 @@ extension InAppDefaultImageOnlyMessageViewController: InAppDefaultImageOnlyViewDelegate { public func imageDidTap() { - if let actionURL = self.actionURL, UIApplication.shared.canOpenURL(actionURL) { - UIApplication.shared.open(actionURL, options: [:], completionHandler: nil) - } - let action = InAppMessagingAction(actionText: nil, actionURL: self.actionURL) eventDetector.messageClicked(with: action) } diff --git a/Sources/SwiftyInAppMessaging/Default/Modal/InAppDefaultModalMessageViewController.swift b/Sources/SwiftyInAppMessaging/Default/Modal/InAppDefaultModalMessageViewController.swift index 8162e1d..a10bd18 100644 --- a/Sources/SwiftyInAppMessaging/Default/Modal/InAppDefaultModalMessageViewController.swift +++ b/Sources/SwiftyInAppMessaging/Default/Modal/InAppDefaultModalMessageViewController.swift @@ -152,11 +152,6 @@ extension InAppDefaultModalMessageViewController: InAppDefaultModalViewDelegate { public func actionButtonDidTap() { - - if let actionURL = self.actionURL, UIApplication.shared.canOpenURL(actionURL) { - UIApplication.shared.open(actionURL, options: [:], completionHandler: nil) - } - let action = InAppMessagingAction( actionText: self.actionButtonText, actionURL: self.actionURL) eventDetector.messageClicked(with: action)