Add flag handling and related tests

Author: fumiya-kume

cmd/mdefaults/flag.go

@@ -0,0 +1,22 @@
+package main
+
+import (
+	"flag"
+	"os"
+)
+
+var (
+	versionFlag bool
+	vFlag       bool
+	verboseFlag bool
+	yesFlag     bool
+)
+
+// initFlags initializes command-line flags
+func initFlags() {
+	flag.CommandLine = flag.NewFlagSet(os.Args[0], flag.ExitOnError)
+	flag.BoolVar(&versionFlag, "version", false, "Print version information")
+	flag.BoolVar(&vFlag, "v", false, "Print version information")
+	flag.BoolVar(&verboseFlag, "verbose", false, "Enable verbose logging")
+	flag.BoolVar(&yesFlag, "y", false, "Automatically confirm prompts")
+}

cmd/mdefaults/flag_test.go

@@ -0,0 +1,99 @@
+package main
+
+import (
+	"flag"
+	"os"
+	"testing"
+)
+
+func TestInitFlags(t *testing.T) {
+	// Save original args and restore after test
+	originalArgs := os.Args
+	defer func() { os.Args = originalArgs }()
+
+	// Reset flags before test
+	flag.CommandLine = flag.NewFlagSet(os.Args[0], flag.ExitOnError)
+
+	// Reset flag variables
+	versionFlag = false
+	vFlag = false
+	verboseFlag = false
+	yesFlag = false
+
+	// Initialize flags
+	initFlags()
+
+	// Test cases
+	testCases := []struct {
+		name     string
+		args     []string
+		flagVar  *bool
+		expected bool
+	}{
+		{"version flag", []string{"cmd", "-version"}, &versionFlag, true},
+		{"v flag", []string{"cmd", "-v"}, &vFlag, true},
+		{"verbose flag", []string{"cmd", "-verbose"}, &verboseFlag, true},
+		{"y flag", []string{"cmd", "-y"}, &yesFlag, true},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			// Reset flags before each test case
+			flag.CommandLine = flag.NewFlagSet(tc.args[0], flag.ExitOnError)
+
+			// Reset flag variables
+			versionFlag = false
+			vFlag = false
+			verboseFlag = false
+			yesFlag = false
+
+			// Initialize flags
+			initFlags()
+
+			// Set args and parse
+			os.Args = tc.args
+			flag.Parse()
+
+			// Check if flag is set correctly
+			if *tc.flagVar != tc.expected {
+				t.Errorf("Expected %v to be %v, got %v", tc.name, tc.expected, *tc.flagVar)
+			}
+		})
+	}
+}
+
+func TestFlagDefaults(t *testing.T) {
+	// Save original args and restore after test
+	originalArgs := os.Args
+	defer func() { os.Args = originalArgs }()
+
+	// Reset flags before test
+	flag.CommandLine = flag.NewFlagSet(os.Args[0], flag.ExitOnError)
+
+	// Reset flag variables
+	versionFlag = false
+	vFlag = false
+	verboseFlag = false
+	yesFlag = false
+
+	// Initialize flags
+	initFlags()
+
+	// Set args without any flags
+	os.Args = []string{"cmd"}
+	flag.Parse()
+
+	// Check default values
+	if versionFlag != false {
+		t.Errorf("Expected versionFlag default to be false, got %v", versionFlag)
+	}
+	if vFlag != false {
+		t.Errorf("Expected vFlag default to be false, got %v", vFlag)
+	}
+	if verboseFlag != false {
+		t.Errorf("Expected verboseFlag default to be false, got %v", verboseFlag)
+	}
+	if yesFlag != false {
+		t.Errorf("Expected yesFlag default to be false, got %v", yesFlag)
+	}
+}

cmd/mdefaults/main.go

@@ -20,21 +20,6 @@ var (
 	architecture string
 )
 
-func initFlags() {
-	flag.CommandLine = flag.NewFlagSet(os.Args[0], flag.ExitOnError)
-	flag.BoolVar(&versionFlag, "version", false, "Print version information")
-	flag.BoolVar(&vFlag, "v", false, "Print version information")
-	flag.BoolVar(&verboseFlag, "verbose", false, "Enable verbose logging")
-	flag.BoolVar(&yesFlag, "y", false, "Automatically confirm prompts")
-}
-
-var (
-	versionFlag bool
-	vFlag       bool
-	verboseFlag bool
-	yesFlag     bool
-)
-
 func setupLogging() {
 	logFile, err := os.OpenFile("mdefaults.log", os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0666)
 	if err != nil {
@@ -64,7 +49,8 @@ func run() int {
 	}
 	configs, err := config.ReadConfigFile(fs)
 	if err != nil {
-		fmt.Println(err)
+		log.Printf("Failed to read config file: %v", err)
+		return 1
 	}
 
 	if verboseFlag {
@@ -126,8 +112,8 @@ func printUsage() {
 }
 
 func printConfigs(configs []config.Config) {
-	for i := 0; i < len(configs); i++ {
-		fmt.Printf("- %s %s %s\n", configs[i].Domain, configs[i].Key, *configs[i].Value)
+	for _, cfg := range configs {
+		fmt.Printf("- %s %s %s\n", cfg.Domain, cfg.Key, *cfg.Value)
 	}
 }
 
@@ -137,6 +123,12 @@ func handlePush(configs []config.Config) int {
 	return 0
 }
 
+// printVersionInfo prints the version and architecture information
+func printVersionInfo() {
+	fmt.Printf("Version: %s\n", version)
+	fmt.Printf("Architecture: %s\n", architecture)
+}
+
 func main() {
 	setupLogging()
 	osType := runtime.GOOS
@@ -147,12 +139,9 @@ func main() {
 	flag.Parse()
 
 	if versionFlag || vFlag {
-		fmt.Printf("Version: %s\n", version)
-		fmt.Printf("Architecture: %s\n", architecture)
+		printVersionInfo()
 		return
 	}
 
-	fmt.Printf("Version: %s\n", version)
-	fmt.Printf("Architecture: %s\n", architecture)
 	os.Exit(run())
 }

cmd/mdefaults/main_test.go

@@ -146,9 +146,6 @@ func mainWithOSType(osType string) {
 		fmt.Printf("Architecture: %s\n", architecture)
 		return
 	}
-
-	fmt.Printf("Version: %s\n", version)
-	fmt.Printf("Architecture: %s\n", architecture)
 	osExit(run())
 }