Commit 0ac3cb2
committed
fix(ci): cron timing doc + concurrency label-stuck race in copilot-review-fix.yml
Two issues caught by Copilot review on the parallel vuls-reach back-port
(vuls-saas/vuls-reach#22), addressed there in 821e3da. The same bugs
exist verbatim in the OSS copy of `copilot-review-fix.yml` (workflow
files were copy-portable across catalog/oss/vuls-reach in the recent
unification). Mirror the fix here so OSS doesn't ship the bugs.
1. **Stale "~5 min" cron-fallback claim** (lines 7-11): comment said
"covers suppressed cases within ~5 min" but `copilot-clean-label.yml`
actually uses `*/30` (cron fires every 30 minutes, worst case ~60 min
— marker posted just after a tick stays fresh on the next tick).
Updated to match the documented 30–60 min recovery window used
elsewhere.
2. **`cancel-in-progress: true` race with label removal** (line 29):
the first step on the labeled-PR path is "Remove copilot-review label
if present" (so the label acts as a single-shot trigger). With
`cancel-in-progress: true`, a new Copilot review/comment event for
the same PR cancels the label-triggered run before that first step
completes, leaving the label stuck on the PR. Re-adding an already-
present label fires no event, so the manual retry path silently
breaks. Switched to `cancel-in-progress: false` so queued events run
sequentially; the marker-based dedup later in the job
(`already_triggered` / `local_in_progress` jq passes) already prevents
duplicate `@claude` posts, so queueing is the safe choice.
The same bugs exist in catalog (#223 already merged) — follow-up PR will
mirror the fix there.1 parent 6faa677 commit 0ac3cb2
1 file changed
Lines changed: 16 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
12 | 14 | | |
13 | | - | |
14 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
15 | 19 | | |
16 | 20 | | |
17 | 21 | | |
| |||
26 | 30 | | |
27 | 31 | | |
28 | 32 | | |
29 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
30 | 42 | | |
31 | 43 | | |
32 | 44 | | |
| |||
0 commit comments