Report diff's #2536
-
|
Has something changed in how report diff functions work in the last few months? I'm getting the same unfixed alerts come through each day via my webook. I've tested this with a single machine and see its the same as when its run for multiple. What I've noticed is that when its doing a diff its comparing the most recent report with the 2nd from first report ever taken - which seems really strange. I've tried wiping the contents of the results directory and starting again, it didn't help. What I run after scan and report local. What the output looks like: Note the Previous json found: /vuls/results/2026-04-25T08-27-25+0000/2fauth-01.json what the results directory looks like: Note the 2026-04-25T08-27-25+0000 Any ideas? Thanks. |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments
-
|
Thanks for the very thorough report — the directory listing and the Confirmed it's a regression. Opened a fix in #2555 that:
Once it's merged you should see |
Beta Was this translation helpful? Give feedback.
-
|
The pull request has been merged. If the issue still persists even after using the latest commit, please reopen it and report it again. |
Beta Was this translation helpful? Give feedback.
Thanks for the very thorough report — the directory listing and the
Previous json foundlog line you included pinpointed this exactly.Confirmed it's a regression.
detector.ListValidJSONDirsis supposed to return result directories newest-first (its doc comment says so, andloadPreviousskipsdirs[0]as the current scan and takesdirs[1]as the previous one). In #2415 (Go 1.26 bump) the original descendingsort.Slicewas modernized toslices.Sort, which sorts ascending — sodirs[0]became the oldest directory anddirs[1]became the second-oldest. That's why your diff always compared against2026-04-25T08-27-25+0000.Opened a fix in #2555 that: