Fix recursive flattening and improve test assertions

Co-authored-by: mballance <1340805+mballance@users.noreply.github.com>

Author: Copilot

src/vsc/coverage.py

@@ -905,17 +905,21 @@ def __init__(self,
                  name=None,
                  iff=None,
                  ignore_bins=None):
-        # Flatten nested crosses by extracting their coverpoints
-        flattened_targets = []
-        for t in target_l:
-            if isinstance(t, cross):
-                # Recursively flatten cross objects
-                flattened_targets.extend(t.target_l)
-            elif isinstance(t, coverpoint):
-                flattened_targets.append(t)
-            else:
-                raise Exception("Cross target \"" + str(t) + "\" is not a coverpoint or cross")
-        self.target_l = flattened_targets
+        # Recursively flatten nested crosses by extracting their coverpoints
+        def flatten_targets(targets):
+            """Recursively flatten a list of coverpoints and crosses."""
+            flattened = []
+            for t in targets:
+                if isinstance(t, cross):
+                    # Recursively flatten cross objects
+                    flattened.extend(flatten_targets(t.target_l))
+                elif isinstance(t, coverpoint):
+                    flattened.append(t)
+                else:
+                    raise Exception("Cross target \"" + str(t) + "\" is not a coverpoint or cross")
+            return flattened
+        
+        self.target_l = flatten_targets(target_l)
         self.bins = bins
         self.options = Options()
 

ve/unit/test_coverage_cross.py

@@ -193,6 +193,7 @@ def __init__(self):
 
         # Verify structure
         self.assertEqual(len(cg.cross_abc.target_l), 3)
-        # Verify options were set
+        # Verify options were set correctly
         self.assertIsNotNone(cg.cross_abc.options)
+        self.assertEqual(cg.cross_abc.options.at_least, 2)