Better code for performance

Author: wildjcrt

app/api/v1/fey_api.rb

@@ -17,8 +17,8 @@ class FeyAPI < Base
           result[:h][0][:name] = term.name if term.lower_name != term.name
           term.descriptions.each do |description|
             description_hash = { f: description.content }
-            description_hash[:e] = description.examples.map(&:content) if description.examples.present?
-            description_hash[:s] = description.synonyms.alts.map(&:content) if description.synonyms.alts.present?
+            description_hash[:e] = description.examples.pluck(:content) if description.examples.present?
+            description_hash[:s] = description.synonyms.alts.pluck(:content) if description.synonyms.alts.present?
             result[:h][0][:d] << description_hash
           end
 

app/api/v1/poinsot_api.rb

@@ -17,8 +17,8 @@ class PoinsotAPI < Base
           result[:h][0][:name] = term.name if term.lower_name != term.name
           term.descriptions.each do |description|
             description_hash = { f: description.content }
-            description_hash[:e] = description.examples.map(&:content) if description.examples.present?
-            description_hash[:s] = description.synonyms.alts.map(&:content) if description.synonyms.alts.present?
+            description_hash[:e] = description.examples.pluck(:content) if description.examples.present?
+            description_hash[:s] = description.synonyms.alts.pluck(:content) if description.synonyms.alts.present?
             description_hash[:type] = description.description_type if description.description_type.present?
             result[:h][0][:d] << description_hash
           end

app/api/v1/safolu_api.rb

@@ -18,9 +18,9 @@ class SafoluAPI < Base
           result[:h][0][:name] = term.name if term.lower_name != term.name
           term.descriptions.each do |description|
             description_hash = { f: description.content }
-            description_hash[:e] = description.examples.map(&:content) if description.examples.present?
-            description_hash[:s] = description.synonyms.alts.map(&:content) if description.synonyms.alts.present?
-            description_hash[:r] = description.synonyms.refs.map(&:content) if description.synonyms.refs.present?
+            description_hash[:e] = description.examples.pluck(:content) if description.examples.present?
+            description_hash[:s] = description.synonyms.alts.pluck(:content) if description.synonyms.alts.present?
+            description_hash[:r] = description.synonyms.refs.pluck(:content) if description.synonyms.refs.present?
             result[:h][0][:d] << description_hash
           end
 

app/controllers/terms_controller.rb

@@ -21,7 +21,7 @@ def show
     end
     id_case_statement.else(10000)
 
-    @dictionaries = Dictionary.where(id: @terms.map(&:dictionary_id).uniq).order(id_case_statement)
+    @dictionaries = Dictionary.where(id: @terms.pluck(:dictionary_id).uniq).order(id_case_statement)
     session[:last_page] = request.url
   end
 end

app/models/term.rb

@@ -71,7 +71,7 @@ def self.ransackable_attributes(auth_object = nil)
 
   def short_description
     Rails.cache.fetch("term-#{name}-#{Date.today}", expires_in: 6.hours) do
-      term_ids = Term.select(:id).where(name: name).order(:dictionary_id).pluck(:id)
+      term_ids = Term.where(name: name).order(:dictionary_id).pluck(:id)
 
       arel_description = Description.arel_table
       case_statement = Arel::Nodes::Case.new(arel_description[:term_id])