Type of 'collectionMoment' vs 'time_of_collection'

[M-casado]

Summary

Beacon-v2 model Biosample's collectionMoment represents Phenopacket's time_of_collection, but has a different, more restrictive, type.

Details

While both entities cover the same semantic space, Beacon's counterpart is a string, with no format, while time_at_collection is a timeElement. I would argue that, having common/timeElement.yaml and even common/age.yaml, it would be appropriate to reference it instead, aligning with the format at source.

beacon-v2/models/src/beacon-v2-default-model/biosamples/defaultSchema.yaml

Lines 47 to 53 in 47af89c

	collectionMoment:
	description: Individual's or cell cullture age at the time of sample collection
	in the ISO8601 duration format `P[n]Y[n]M[n]DT[n]H[n]M[n]S`.
	type: string
	examples:
	- P32Y6M1D
	- P7D