Skip to content

Commit ccf4bb5

Browse files
authored
Merge pull request #401 from ga4gh/typos
Fixing five typos
2 parents 9b61383 + 6e9b119 commit ccf4bb5

9 files changed

Lines changed: 16 additions & 12 deletions

File tree

docs/basics.rst

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,9 @@ to a phenotypic feature, such as `Arachnodactyly <https://hpo.jax.org/app/browse
3737
component of a disease, such as `Marfan syndrome <https://hpo.jax.org/app/browse/disease/OMIM:154700>`_. The
3838
Phenopacket proposed here is designed to support `deep phenotyping <https://www.ncbi.nlm.nih.gov/pubmed/22504886>`_, a
3939
process wherein individual components of each phenotype are observed and documented. The phenotypes may be
40-
constitutional or those related to a sample (such as from a biopsy).
40+
constitutional or those related to a sample (such as from a biopsy).
41+
42+
The Phenopacket Schema was developed under the aegis of the `GA4GH <https://www.ga4gh.org/>`_ (2015-2022).
43+
44+
- `Jacobsen JOB, et al. (2022) The GA4GH Phenopacket schema defines a computable representation of clinical data. Nat Biotechnol <https://pubmed.ncbi.nlm.nih.gov/35705716/>`_
45+
- `Ladewig MS, et al. (2022) GA4GH Phenopackets: A Practical Introduction. Adv Genet (Hoboken) <https://pubmed.ncbi.nlm.nih.gov/36910590/>`_

docs/fhir.rst

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ FHIR Implementation Guide
66

77
Phenopacket on FHIR is a Fast Healthcare Interoperability Resources (FHIR) Implementation Guide (IG) based on the Phenopacket standard. It is meant to be conceptually equivalent but not directly interoperable. The guide is hosted at:
88

9-
http://phenopackets.org/core-ig/master/
10-
11-
A list of the FHIR artifacts defined as part of this implementation guide can be found at http://phenopackets.org/core-ig/master/artifacts.html
9+
https://github.com/phenopackets/phenopacket-schema-fhir-implementation-guide
1210

1311
Briefly, the implementation guide includes definitions for the properties by which a RESTFUL server can be queried (Search Parameters), the constraints on FHIR resources for systems (Resource Profiles) and on FHIR data types (Extension Definitions) conforming to this implementation guide, and the existent sets of codes (Value Sets) and new Code Systems used by systems that conform to the Phenopacket FHIR IG.
1412

docs/ontologies.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ in this recent `review <https://www.ncbi.nlm.nih.gov/pubmed/30304648>`_.
1616

1717
While both terminologies and ontologies can be used, the phenopacket schema recommends the use of specific ontologies in order to maximize utility of performing algorithmic analysis over medically relevant abnormalities.
1818

19-
The `Human Phenotype Ontology (HPO) <http://www.human-phenotype-ontology.org>`_ describes patient phenotypic features and was originally designed for genomic diagnostics, translational research, genomic matchmaking, and systems biology applications in the field of rare disease and other fields of medicine. It is increasinly used within clinical applications today for precision medicine.
19+
The `Human Phenotype Ontology (HPO) <http://www.human-phenotype-ontology.org>`_ describes patient phenotypic features and was originally designed for genomic diagnostics, translational research, genomic matchmaking, and systems biology applications in the field of rare disease and other fields of medicine. It is increasingly used within clinical applications today for precision medicine.
2020

2121
The HPO is developed in the context of the `Monarch Initiative <https://monarchinitiative.org/>`_, an international team of
2222
computer scientists, clinicians, and biologists in the United States, Europe, and Australia;

docs/pedigree.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,8 @@ This element is an enumeration to
139139
In a PED file, affected persons are encoded with "2", and unaffecteds by "1"
140140
(a "0" is used if no information is available). Instead, Phenopackets uses an enumeration as shown in the table.
141141

142-
In a PED file, the sex of individuals is encoded as a "1" for females, "2" for males, and "0" for unknown. Phenopackets
143-
uses :ref:`rstsex` instead.
142+
In a PED file, the sex of individuals is encoded as a "2" for females, "1" for males, and "0" for unknown. Phenopackets
143+
uses :ref:`rstsex` instead (Note that the enumeration used for Sex by the Phenopacket Schema has 1 for FEMALE and 2 for MALE, but this is internal and is not visible in the JSON-serialized Phenopacket).
144144

145145
The message is made up of a list of ``Person`` elements (the Person element is defined within the Pedigree element).
146146
Each Person element is equivalent to one row of a PED file.

docs/procedure.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ Procedure
77
The Procedure element represents a clinical procedure performed on a subject. For example a surgical or diagnostic
88
procedure such as a biopsy.
99

10+
1011
By preference a single ``code`` to indicate both the procedure and the
1112
body site should be used. In cases where this is not possible, the body site should be indicated using a separate
1213
ontology class.

docs/protobuf.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ it is not possible to define a field as required.
6262
syntax = "proto3";
6363
6464
message dog {
65-
required string name = 1;
65+
string name = 1;
6666
int32 weight = 2;
67-
repeated string toys = 4;
67+
repeated string toys = 3;
6868
}
6969
7070
We can compile this code with the following command

docs/recommended-ontologies.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ medical data. The following table shows some typical examples.
127127

128128
Genotypes
129129
#########
130-
GENO is anontology of genotypes their more fundamental sequence components, and links to related biological
130+
GENO is an ontology of genotypes their more fundamental sequence components, and links to related biological
131131
and experimental entities. We use GENO terms to denote genotypes.
132132

133133

docs/resource.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ For an ontology, the url SHALL point to the obo or owl file, e.g. This informati
3737
resource:
3838
id: "hp"
3939
name: "Human Phenotype Ontology"
40-
url: "http://www.human-phenotype-ontology.org"
40+
url: "http://purl.obolibrary.org/obo/hp.owl"
4141
version: "2018-03-08"
4242
namespacePrefix: "HP"
4343
iriPrefix: "http://purl.obolibrary.org/obo/HP_"

docs/timestamp.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Timestamp
66

77
In phenopackets we define the `Timestamp` as an `ISO-8601 date time <https://en.wikipedia.org/wiki/ISO_8601#Combined_date_and_time_representations>`_ string.
88

9-
The following documentation paraphrases the description of how this is represented in protobuf as JSON `Timestamp <https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/Timestamp>`_
9+
The following documentation paraphrases the description of how a Timestamp is represented in protobuf as JSON (See `Timestamp <https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/Timestamp>`_).
1010

1111
The format for this is "{year}-{month}-{day}T{hour}:{min}:{sec}[.{frac_sec}]Z" where {year} is always expressed using
1212
four digits while {month}, {day}, {hour}, {min}, and {sec} are zero-padded to two digits each. The fractional seconds,

0 commit comments

Comments
 (0)