Skip to content

Commit 6dd928d

Browse files
committed
Undo fix #529 (causes a warning under gcc and clang when no args passed)
1 parent de595fe commit 6dd928d

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

include/spdlog/spdlog.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,13 +165,15 @@ void drop_all();
165165
///////////////////////////////////////////////////////////////////////////////
166166

167167
#ifdef SPDLOG_TRACE_ON
168+
#define SPDLOG_STR_H(x) #x
169+
#define SPDLOG_STR_HELPER(x) SPDLOG_STR_H(x)
168170
#ifdef _MSC_VER
169-
#define SPDLOG_TRACE(logger, s, ...) logger->trace(fmt::format("[ {}({}) ] {}", __FILE__, __LINE__, (s)).c_str(), ##__VA_ARGS__);
171+
#define SPDLOG_TRACE(logger, ...) logger->trace("[ " __FILE__ "(" SPDLOG_STR_HELPER(__LINE__) ") ] " __VA_ARGS__)
170172
#else
171-
#define SPDLOG_TRACE(logger, s, ...) logger->trace(fmt::format("[ {}:{} ] {}", __FILE__, __LINE__, (s)).c_str(), ##__VA_ARGS__);
173+
#define SPDLOG_TRACE(logger, ...) logger->trace("[ " __FILE__ ":" SPDLOG_STR_HELPER(__LINE__) " ] " __VA_ARGS__)
172174
#endif
173175
#else
174-
#define SPDLOG_TRACE(logger, s, ...)
176+
#define SPDLOG_TRACE(logger, ...)
175177
#endif
176178

177179
#ifdef SPDLOG_DEBUG_ON

0 commit comments

Comments
 (0)