Strip tilde from Sourcehut usernames in output dir

Author: gabrie30

CHANGELOG.md

@@ -3,14 +3,17 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 
-## [1.11.6] - unreleased
+## [1.11.6] - 11/6/25
 ### Added
 - Sourcehut as a new SCM provider; thanks @shabbyrobe
 ### Changed
 ### Deprecated
 ### Removed
 ### Fixed
 ### Security
+- Bump gitlab.com/gitlab-org/api/client-go from 0.150.0 to 0.157.1 (#592)
+- Bump code.gitea.io/sdk/gitea from 0.22.0 to 0.22.1 (#591)
+- Bump golang.org/x/oauth2 from 0.31.0 to 0.32.0 (#590)
 
 ## [1.11.5] - 10/30/25
 ### Added

cmd/clone.go

@@ -1314,6 +1314,11 @@ func setOutputDirName(argz []string) {
 
 	outputDirName = strings.ToLower(argz[0])
 
+	// Strip ~ prefix for sourcehut usernames to avoid shell expansion issues
+	if os.Getenv("GHORG_SCM_TYPE") == "sourcehut" {
+		outputDirName = strings.TrimPrefix(outputDirName, "~")
+	}
+
 	if os.Getenv("GHORG_PRESERVE_SCM_HOSTNAME") != "true" {
 		// If all-group is used set the parent folder to the name of the baseurl
 		if argz[0] == "all-groups" && os.Getenv("GHORG_SCM_BASE_URL") != "" {

cmd/clone_test.go

@@ -58,6 +58,64 @@ func TestShouldNotChangeNonLettersString(t *testing.T) {
 	}
 }
 
+func TestSourcehutStripsTildePrefix(t *testing.T) {
+	defer UnsetEnv("GHORG_")()
+
+	usernameWithTilde := "~gabrie30"
+	os.Setenv("GHORG_SCM_TYPE", "sourcehut")
+	defer setOutputDirName([]string{""})
+	setOutputDirName([]string{usernameWithTilde})
+
+	expected := "gabrie30"
+	if outputDirName != expected {
+		t.Errorf("Wrong folder name for sourcehut with tilde, expected: %s, got: %s", expected, outputDirName)
+	}
+}
+
+func TestSourcehutWithoutTildePrefix(t *testing.T) {
+	defer UnsetEnv("GHORG_")()
+
+	usernameWithoutTilde := "gabrie30"
+	os.Setenv("GHORG_SCM_TYPE", "sourcehut")
+	defer setOutputDirName([]string{""})
+	setOutputDirName([]string{usernameWithoutTilde})
+
+	expected := "gabrie30"
+	if outputDirName != expected {
+		t.Errorf("Wrong folder name for sourcehut without tilde, expected: %s, got: %s", expected, outputDirName)
+	}
+}
+
+func TestSourcehutStripsTildePrefixUppercase(t *testing.T) {
+	defer UnsetEnv("GHORG_")()
+
+	usernameWithTilde := "~Gabrie30"
+	os.Setenv("GHORG_SCM_TYPE", "sourcehut")
+	defer setOutputDirName([]string{""})
+	setOutputDirName([]string{usernameWithTilde})
+
+	// Should be lowercased AND have tilde stripped
+	expected := "gabrie30"
+	if outputDirName != expected {
+		t.Errorf("Wrong folder name for sourcehut with uppercase and tilde, expected: %s, got: %s", expected, outputDirName)
+	}
+}
+
+func TestNonSourcehutPreservesTilde(t *testing.T) {
+	defer UnsetEnv("GHORG_")()
+
+	usernameWithTilde := "~user123"
+	os.Setenv("GHORG_SCM_TYPE", "github")
+	defer setOutputDirName([]string{""})
+	setOutputDirName([]string{usernameWithTilde})
+
+	// For non-sourcehut SCMs, tilde should be preserved (even though it's unusual)
+	expected := "~user123"
+	if outputDirName != expected {
+		t.Errorf("Wrong folder name for github with tilde, expected: %s, got: %s", expected, outputDirName)
+	}
+}
+
 type MockGitClient struct{}
 
 func NewMockGit() MockGitClient {