Fix fds leaking after log truncation (#540)

Co-authored-by: Laurentiu Cristofor <[email protected]>

Author: LaurentiuCristofor

production/db/core/src/db_client.cpp

@@ -587,6 +587,11 @@ void client::rollback_transaction()
     size_t log_size;
     s_log.truncate_seal_and_close(fd_log, log_size);
 
+    // We now own destruction of fd_log.
+    auto cleanup_fd_log = make_scope_guard([&]() {
+        close_fd(fd_log);
+    });
+
     // Avoid sending transaction log fd to the server read only transactions.
     if (log_size > 0)
     {
@@ -623,6 +628,11 @@ void client::commit_transaction()
     size_t log_size;
     s_log.truncate_seal_and_close(fd_log, log_size);
 
+    // We now own destruction of fd_log.
+    auto cleanup_fd_log = make_scope_guard([&]() {
+        close_fd(fd_log);
+    });
+
     // Send the server the commit event with the log segment fd.
     FlatBufferBuilder builder;
     build_client_request(builder, session_event_t::COMMIT_TXN);