Allow empty tables to be used in rulesets (#1404)

* Allow empty tables to be used in rulesets

* Move the test to different ddl to avoid polluting ddl used for other examples

Author: fineg74

production/schemas/test/prerequisites/prerequisites.ddl

@@ -86,3 +86,12 @@ table person (
     floor references floor
         where person.floor_num = floor.num
 )
+
+table state (
+    pick bool,
+    place bool
+)
+
+table pick_action ()
+
+table move_action ()

production/tools/gaia_translate/src/main.cpp

@@ -742,7 +742,10 @@ void generate_navigation(StringRef anchor_table, Rewriter& rewriter)
                 replacement_string.append(",");
             }
         }
-        replacement_string.resize(replacement_string.size() - 1);
+        if (!function_arguments.empty())
+        {
+            replacement_string.resize(replacement_string.size() - 1);
+        }
         replacement_string.append("))");
 
         rewriter.ReplaceText(insert_data.expression_range, replacement_string);

production/tools/gaia_translate/tests/test_rulesets.ruleset

@@ -824,3 +824,23 @@ ruleset vlr_rules
         gaia_log::app().info("---");
     }
 }
+
+ruleset pick_and_place_ruleset
+{
+    {
+        if (@pick && !@place)
+        {
+            pick_action.insert();
+        }
+    }
+
+    on_insert(pick_action)
+    {
+        move_action.insert();
+    }
+
+    on_insert(move_action)
+    {
+        gaia_log::app().info("Moving...");
+    }
+}

third_party/production/TranslationEngineLLVM/clang/lib/Catalog/GaiaCatalog.cpp

@@ -100,6 +100,7 @@ void GaiaCatalog::fillTableData()
                 continue;
             }
             CatalogTableData table_data;
+            table_data.dbName = table.database().name();
             m_catalogTableData[table.name()] = table_data;
         }
 
@@ -133,8 +134,8 @@ void GaiaCatalog::fillTableData()
                 m_catalogTableData.clear();
                 return;
             }
-            CatalogTableData table_data = table_data_iterator->second;
-            if (table_data.fieldData.find(field.name()) != table_data.fieldData.end())
+
+            if (table_data_iterator->second.fieldData.find(field.name()) != table_data_iterator->second.fieldData.end())
             {
                 m_diags.Report(diag::err_duplicate_field) << field.name();
                 m_catalogTableData.clear();
@@ -146,9 +147,7 @@ void GaiaCatalog::fillTableData()
             field_data.isDeprecated = field.deprecated();
             field_data.isArray = field.repeated_count() == 0;
             field_data.fieldType = static_cast<data_type_t>(field.type());
-            table_data.dbName = table.database().name();
-            table_data.fieldData[field.name()] = field_data;
-            m_catalogTableData[table.name()] = table_data;
+            table_data_iterator->second.fieldData[field.name()] = field_data;
         }
 
         for (const auto& relationship : gaia_relationship_t::list())