grey out google oauth buttons instead of hiding them out in staging ande

controlled in dev by env var

Author: papes1ns

app/views/devise/registrations/new.html.haml

@@ -31,11 +31,15 @@
         = f.password_field :password_confirmation,
                            class: %w[pt-input pt-fill] + error_classes,
                            autocomplete: "new-password"
-
       = f.submit t('.sign_up'), class: %w[pt-intent-primary]
       - if ENV['TEMPORARY_UNCONFIRMED_ACCESS'] == 'false'
-        %a.pt-button.pt-icon-log-in.oauth-icon-google{role: 'button',
-          href: omniauth_authorize_path('authentication_strategy', 'google')}
+        %a.pt-button.pt-icon-log-in.oauth-icon-google{ role: 'button', tabindex: '0',
+          href: omniauth_authorize_path('authentication_strategy', 'google') }
+          = t('devise.shared.links.sign_in_with_provider', provider: 'Google')
+      - else
+        %a.pt-button.pt-icon-log-in.oauth-icon-google.pt-disabled{ role: 'button', tabindex: '-1',
+          href: 'javascript:void(0)',
+          style: 'pointer-events: none; opacity: 0.6;' }
           = t('devise.shared.links.sign_in_with_provider', provider: 'Google')
 
     = render "devise/shared/links"

app/views/devise/sessions/_sign_in.html.haml

@@ -20,5 +20,10 @@
     %a.pt-button.pt-icon-log-in.oauth-icon-google{ role: 'button', tabindex: '0',
       href: omniauth_authorize_path('authentication_strategy', 'google') }
       = t('devise.shared.links.sign_in_with_provider', provider: 'Google')
+  - else
+    %a.pt-button.pt-icon-log-in.oauth-icon-google.pt-disabled{ role: 'button', tabindex: '-1',
+      href: 'javascript:void(0)',
+      style: 'pointer-events: none; opacity: 0.6;' }
+      = t('devise.shared.links.sign_in_with_provider', provider: 'Google')
 
 = render "devise/shared/links"

config/application.rb

@@ -11,13 +11,13 @@
 
 # Set release version
 ENV['RELEASE'] = 'v2.2.0' # TODO: experiment doing github releases again
+
 # Determine if we're in staging environment
 ENV['STAGING'] = (ENV['BASE_URL']&.include?('staging')).to_s
+
 # Allow temporary unconfirmed access in staging or development
 ENV['TEMPORARY_UNCONFIRMED_ACCESS'] ||=
-  (ENV['STAGING'] == 'true' || Rails.env.development?).to_s
-
-puts [ENV['RELEASE'], ENV['STAGING'], ENV['TEMPORARY_UNCONFIRMED_ACCESS']].inspect
+  (ENV['STAGING'] == 'true').to_s
 
 module Orchard
   class Application < Rails::Application
@@ -35,6 +35,5 @@ class Application < Rails::Application
     unless ENV['SIDEKIQ_CONCURRENCY'].present?
       config.middleware.use Rack::Deflater
     end
-
   end
 end

docker-compose.yml

@@ -18,6 +18,7 @@ services:
       SIDEKIQ_CONCURRENCY: 1
       RUBY_YJIT_ENABLE: 1
       DOCKER_DEV: true
+      TEMPORARY_UNCONFIRMED_ACCESS: false
       BASE_URL: http://localhost:3000
       PORT: 3000
     ports: