Skip to content

Commit 7263f0e

Browse files
authored
Tweaks (#77)
Tweaks
2 parents 5de7853 + d4be2e7 commit 7263f0e

File tree

5 files changed

+10
-13
lines changed

5 files changed

+10
-13
lines changed

app/assets/stylesheets/flash.sass

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
.flash
44
font: 90% $sansFont
55
color: $white
6-
text-transform: uppercase
76
text-align: center
8-
letter-spacing: 0.05em
97
width: 100%
108
padding: 0.2em
119
border-bottom-width: 2px
@@ -26,12 +24,11 @@
2624
.flash-notice
2725
background-color: darken($lightGreen, 10%)
2826
border-bottom-color: darken($lightGreen, 20%)
27+
color: $black
2928

3029
.flash-info
3130
background-color: #1d3f5e
3231
border-bottom-color: #193c5b
33-
text-transform: initial
34-
letter-spacing: 0em
3532

3633
.flash-editing
3734
background-color: $white

app/assets/stylesheets/structure.sass

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,17 +51,17 @@ header
5151
cursor: pointer
5252

5353
.dismiss
54-
z-index: 40
54+
z-index: 10
5555

5656
#reader-icon
5757
position: absolute
58-
z-index: 50
58+
z-index: 11
5959
right: 3em
6060

6161
ul#reader-menu-dropdown
6262
background-color: $purple
6363
position: absolute
64-
z-index: 50
64+
z-index: 11
6565
min-width: 10em
6666
top: -1em
6767
right: -1em
@@ -93,7 +93,7 @@ header
9393
position: absolute
9494
top: 2.1em
9595
right: 1.4em
96-
z-index: 100
96+
z-index: 12
9797

9898
#reader-icon
9999
font-size: 90%

app/javascript/quiz/PreTest.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const PreTest = ({
3333
className="pt-dark"
3434
isOpen={!!match}
3535
title="Before you get started"
36-
style={{ top: '10%', width: 800 }}
36+
style={{ top: '10%', width: '100%', maxWidth: 800 }}
3737
onClose={() => {
3838
history.replace('/')
3939
}}

app/javascript/quiz/Quiz.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export function providesQuiz (
5858

5959
return questions.map(x => x.id).every(x => {
6060
const answer = this.state[x]
61-
return answer && answer.length > 0
61+
return answer && answer.trim().length > 0
6262
})
6363
}
6464

spec/features/signing_up_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@
1515
fill_in 'Password', with: password, match: :first
1616
fill_in 'Password confirmation', with: password
1717
click_button 'Sign up'
18-
expect(page).to have_content 'CONFIRMATION LINK'
18+
expect(page).to have_content 'confirmation link'
1919

2020
reader = Reader.find_by_email email
2121
visit reader_confirmation_path confirmation_token: reader.confirmation_token
22-
expect(page).to have_content 'SUCCESSFULLY CONFIRMED'
22+
expect(page).to have_content 'successfully confirmed'
2323

2424
fill_in 'Email', with: email
2525
fill_in 'Password', with: password
2626
click_button 'Sign in'
27-
expect(page).to have_content 'SIGNED IN SUCCESSFULLY'
27+
expect(page).to have_content 'Signed in successfully'
2828
end
2929
end

0 commit comments

Comments
 (0)