Skip to content

Add odv collection manager#154

Closed
Marie59 wants to merge 11 commits intogalaxyecology:masterfrom
Marie59:master
Closed

Add odv collection manager#154
Marie59 wants to merge 11 commits intogalaxyecology:masterfrom
Marie59:master

Conversation

@Marie59
Copy link
Copy Markdown
Collaborator

@Marie59 Marie59 commented Mar 11, 2025

Add new ocean biogeochemical tool.

TO DO

  • Find a test file not too big the one I have is to big ...

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you remove this tool, any reason?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh but what is that ...
Maybe my branch was not up to date ...

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finish improving here I'll open another PR on a up to data branch ...

Comment thread tools/ocean_data_view_manager/tool_odv.xml Outdated
Comment thread tools/ocean_data_view_manager/tool_odv.xml Outdated
Comment thread tools/ocean_data_view_manager/tool_odv.xml Outdated
</param>
<when value="yes">
<param name="operator" type="text" label="Enter operator name"/>
<param name="qc_convention" type="text" value="ARGO" label="Enter QC convention (default: ARGO)"/>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What else is possible, how do people now. Should this be a select?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes probably ! i'll ask to imrpove that

<option value="no">No, I don't have my a configuration file, I use the default one</option>
<option value="yes">Yes, I do have my own configuration file</option>
</param>
<when value="yes">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saying most of the label and help text I do not understand. Is it expected that this tool is only used by ODV experts?

Copy link
Copy Markdown
Collaborator Author

@Marie59 Marie59 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes pretty much, We need to improve a bit the labels and the help but this not for beginners but for ODV experts

Comment thread tools/ocean_data_view_manager/tool_odv.xml Outdated
Marie59 and others added 5 commits March 11, 2025 09:58
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
@Marie59 Marie59 closed this Mar 11, 2025
@Marie59
Copy link
Copy Markdown
Collaborator Author

Marie59 commented Mar 11, 2025

OPening up on a clean branch oups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants