Skip to content

Commit 7b725df

Browse files
committed
Fix mypy type errors in run_request.py
- Use isinstance checks for proper type narrowing instead of attribute access - Use distinct variable names (hdca_input, hda_input) to avoid type conflicts - Add necessary type imports from tool_util_models.parameters https://claude.ai/code/session_01QWGeMjFzqh1JECMNdUo6mQ
1 parent 9577ed2 commit 7b725df

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

lib/galaxy/workflow/run_request.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,12 @@
2929
WorkflowRequestStepState,
3030
)
3131
from galaxy.model.base import ensure_object_added_to_session
32-
from galaxy.tool_util_models.parameters import DataOrCollectionRequestAdapter
32+
from galaxy.tool_util_models.parameters import (
33+
DataOrCollectionRequestAdapter,
34+
DataRequestCollectionUri,
35+
DataRequestUri,
36+
FileRequestUri,
37+
)
3338
from galaxy.tools.parameters.basic import ParameterValueError
3439
from galaxy.tools.parameters.meta import expand_workflow_inputs
3540
from galaxy.tools.parameters.workflow_utils import NO_REPLACEMENT
@@ -422,20 +427,20 @@ def build_workflow_run_configs(
422427
content = app.dataset_collection_manager.get_dataset_collection_instance(
423428
trans, "history", data_request.id
424429
)
425-
elif data_request.class_ == "Collection":
426-
request_input = dereference_input_to_hdca(trans, data_request, history)
430+
elif isinstance(data_request, DataRequestCollectionUri):
431+
hdca_input = dereference_input_to_hdca(trans, data_request, history)
427432
added_to_history = True
428433
content = InputWithRequest(
429-
input=request_input,
434+
input=hdca_input,
430435
request=data_request.model_dump(mode="json"),
431436
)
432437
if not data_request.deferred:
433438
requires_materialization = True
434-
elif data_request.src == "url" or data_request.class_ == "File":
435-
request_input = dereference_input_to_hda(trans, data_request, history)
439+
elif isinstance(data_request, (DataRequestUri, FileRequestUri)):
440+
hda_input = dereference_input_to_hda(trans, data_request, history)
436441
added_to_history = True
437442
content = InputWithRequest(
438-
input=request_input,
443+
input=hda_input,
439444
request=data_request.model_dump(mode="json"),
440445
)
441446
if not data_request.deferred:

0 commit comments

Comments
 (0)