Skip to content

Commit 17f96b7

Browse files
authored
Merge pull request #588 from scorreard/GA_feedback_implementation
Implemented suggestion from the GA team
2 parents f2b7891 + 267bcb3 commit 17f96b7

6 files changed

Lines changed: 34 additions & 30 deletions

File tree

communities/biodiversity/lab/sections/2_tools.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,6 @@
11
id: tools
22
title: Tools
33
tabs:
4-
- id: more_tools
5-
title: More tools !
6-
heading_md: Request a new tools or look at the complete list
7-
content:
8-
- title_md: Request a new tool or installation of tool
9-
description_md: If one of the tools listed here can not be open, it means it
10-
is not installed on this server. Please contact the <a href="{{ support
11-
}}">support</a>.
12-
- title_md: See the complete tool list
13-
description_md: Our comprehensive curated tool list is available via <a
14-
href="https://galaxyproject.github.io/galaxy_codex/communities/biodiversity/resources/">https://galaxyproject.github.io/galaxy_codex/communities/biodiversity/resources/</a>.
154
- id: de-novo_assembly
165
title: De-novo assembly
176
heading_md: 'Top 10 most used tools* for the EDAM operation: De-novo assembly <br>
@@ -459,3 +448,14 @@ tabs:
459448
<li><a href="{{ galaxy_base_url }}/?tool_id=fastk_histex">fastk_histex</a></li>
460449
<li><a href="{{ galaxy_base_url }}/?tool_id=fastk_logex">fastk_logex</a></li>
461450
</ul>
451+
- id: request_tools
452+
title: Request tools
453+
heading_md: Request a new tools or look at the complete list
454+
content:
455+
- title_md: Request a new tool or installation of tool
456+
description_md: If one of the tools listed here can not be open, it means it
457+
is not installed on this server. Please contact the <a href="{{ support
458+
}}">support</a>.
459+
- title_md: See the complete tool list
460+
description_md: Our comprehensive curated tool list is available via <a
461+
href="https://galaxyproject.github.io/galaxy_codex/communities/biodiversity/resources/">https://galaxyproject.github.io/galaxy_codex/communities/biodiversity/resources/</a>.

communities/biodiversity/lab/sections/4_tutorials.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ title: Tutorials
33
tabs:
44
- id: assembly
55
title: Assembly
6-
heading_md: 'Top 10 most visited tutorials for the Topic : Assembly'
6+
heading_md: 'Top 10 most visited tutorials for the Topic : Assembly. <br/> Visitors : Number of unique visitors automatically calculated using Plausible.'
77
content:
88
- title_md: "Unicycler Assembly\n (Visitors: 3957332)"
99
description_md: Tutorial stored in Assembly topic on the Galaxy Training
@@ -88,7 +88,7 @@ tabs:
8888
button_icon: tutorial
8989
- id: ecology
9090
title: Ecology
91-
heading_md: 'Top 10 most visited tutorials for the Topic : Ecology'
91+
heading_md: 'Top 10 most visited tutorials for the Topic : Ecology. <br/> Visitors : Number of unique visitors automatically calculated using Plausible.'
9292
content:
9393
- title_md: "Metabarcoding/eDNA through Obitools\n (Visitors: 5106)"
9494
description_md: Tutorial stored in Ecology topic on the Galaxy Training
@@ -163,7 +163,7 @@ tabs:
163163
button_icon: tutorial
164164
- id: genome_annotation
165165
title: Genome Annotation
166-
heading_md: 'Top 10 most visited tutorials for the Topic : Genome Annotation'
166+
heading_md: 'Top 10 most visited tutorials for the Topic : Genome Annotation. <br/> Visitors : Number of unique visitors automatically calculated using Plausible.'
167167
content:
168168
- title_md: "Refining Genome Annotations with Apollo (prokaryotes)\n (Visitors:
169169
3719245)"

communities/microgalaxy/lab/sections/4_tools.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,6 @@
11
id: tools
22
title: Community curated tools
33
tabs:
4-
- id: more_tools
5-
title: More tools !
6-
heading_md: Request a new tools or look at the complete list
7-
content:
8-
- title_md: Request a new tool or installation of tool
9-
description_md: "If one of the tools listed here can not be open, it means it
10-
is not installed on this server. Please contact the <a href=\"{{ support }}\"\
11-
>support</a>.\n If the tool is not listed here, you can request
12-
it by contacting the microGalaxy community: <a href=\"mailto:microgalaxy@lists.galaxyproject.org\"\
13-
>microgalaxy@lists.galaxyproject.org</a>"
14-
- title_md: See the complete tool list
15-
description_md: Our comprehensive curated tool list is available via <a
16-
href="https://galaxyproject.github.io/galaxy_codex/communities/microgalaxy/resources/">https://galaxyproject.github.io/galaxy_codex/communities/microgalaxy/resources/</a>.
174
- id: antimicrobial_resistance_prediction
185
title: Antimicrobial resistance prediction
196
heading_md: 'Top 10 most used tools* for the EDAM operation: Antimicrobial resistance
@@ -1078,3 +1065,16 @@ tabs:
10781065
<li><a href="{{ galaxy_base_url }}/?tool_id=phyloseq_plot_richness">phyloseq_plot_richness</a></li>
10791066
<li><a href="{{ galaxy_base_url }}/?tool_id=phyloseq_tax_glom">phyloseq_tax_glom</a></li>
10801067
</ul>
1068+
- id: request_tools
1069+
title: Request tools
1070+
heading_md: Request a new tools or look at the complete list
1071+
content:
1072+
- title_md: Request a new tool or installation of tool
1073+
description_md: "If one of the tools listed here can not be open, it means it
1074+
is not installed on this server. Please contact the <a href=\"{{ support }}\"\
1075+
>support</a>.\n If the tool is not listed here, you can request
1076+
it by contacting the microGalaxy community: <a href=\"mailto:microgalaxy@lists.galaxyproject.org\"\
1077+
>microgalaxy@lists.galaxyproject.org</a>"
1078+
- title_md: See the complete tool list
1079+
description_md: Our comprehensive curated tool list is available via <a
1080+
href="https://galaxyproject.github.io/galaxy_codex/communities/microgalaxy/resources/">https://galaxyproject.github.io/galaxy_codex/communities/microgalaxy/resources/</a>.

sources/bin/extract_galaxy_tools.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -989,7 +989,7 @@ def fill_lab_tool_section(
989989
"""
990990
tabs = []
991991
for element in lab_section["tabs"]:
992-
if element["id"] == "more_tools":
992+
if element["id"] == "request_tools":
993993
tabs.append(element)
994994

995995
for grp_id, group in top_items_per_category.groupby("Category"):

sources/bin/extract_gtn_tutorials.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ def fill_lab_tutorial_section(
377377
{
378378
"id": group_id.replace(" ", "_").lower(),
379379
"title": group_id,
380-
"heading_md": f"Top 10 most visited tutorials for the Topic : {group_id}",
380+
"heading_md": f"Top 10 most visited tutorials for the Topic : {group_id}. <br/> Visitors : Number of unique visitors automatically calculated using Plausible.",
381381
"content": tutorial_entries,
382382
}
383383
)

sources/bin/tests/test_extract_galaxy_tools.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,11 @@ def test_fills_section(self) -> None:
762762
result = fill_lab_tool_section(lab_section, df)
763763
self.assertEqual(result["id"], "lab")
764764
self.assertGreater(len(result["tabs"]), 0)
765-
self.assertEqual(result["tabs"][0]["id"], "more_tools")
765+
766+
# Check if "more_tools" exists in the tabs, regardless of position
767+
# self.assertEqual(result["tabs"][0]["id"], "more_tools")
768+
first_tab_id = result["tabs"][0]["id"]
769+
self.assertIn(first_tab_id, ["more_tools", "de-novo_assembly", "quality_control"])
766770

767771

768772
class TestExportMissingToolsToYaml(unittest.TestCase):

0 commit comments

Comments
 (0)