Skip to content

Commit a128fcf

Browse files
committed
THE FIX IS IN! Common.Logging was somehow causing a namespace clash/conflict in projects with Unity Collections in it, which is basically all of them by default in recent releases. So, this fix completely removes log4net, which references Common.Logging, and replaced it with straight up C# so that GONetLog is good to go on all platforms, all Unity versions, high performance, multithread capable and writes to a file and console...a drop in replacement without the log4net+Common.Logging woesgit add .git add .
1 parent 4695e0c commit a128fcf

12 files changed

Lines changed: 771 additions & 31669 deletions

Assembly-CSharp-Editor.csproj

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -479,22 +479,14 @@
479479
<HintPath>Library\PackageCache\com.unity.collab-proxy@2.2.0\Lib\Editor\PlasticSCM\Unity.Plastic.Newtonsoft.Json.dll</HintPath>
480480
<Private>False</Private>
481481
</Reference>
482-
<Reference Include="log4net">
483-
<HintPath>Assets\GONet\Plugins\log4net\log4net.dll</HintPath>
484-
<Private>False</Private>
485-
</Reference>
486-
<Reference Include="Common.Logging">
487-
<HintPath>Assets\GONet\Plugins\log4net\Common.Logging.dll</HintPath>
482+
<Reference Include="log4netPlastic">
483+
<HintPath>Library\PackageCache\com.unity.collab-proxy@2.2.0\Lib\Editor\PlasticSCM\log4netPlastic.dll</HintPath>
488484
<Private>False</Private>
489485
</Reference>
490486
<Reference Include="Newtonsoft.Json">
491487
<HintPath>Library\PackageCache\com.unity.nuget.newtonsoft-json@3.2.1\Runtime\Newtonsoft.Json.dll</HintPath>
492488
<Private>False</Private>
493489
</Reference>
494-
<Reference Include="log4netPlastic">
495-
<HintPath>Library\PackageCache\com.unity.collab-proxy@2.2.0\Lib\Editor\PlasticSCM\log4netPlastic.dll</HintPath>
496-
<Private>False</Private>
497-
</Reference>
498490
<Reference Include="UnityEditor.iOS.Extensions.Xcode">
499491
<HintPath>C:\Program Files\Unity\Hub\Editor\2022.3.12f1\Editor\Data\PlaybackEngines\AppleTVSupport\UnityEditor.iOS.Extensions.Xcode.dll</HintPath>
500492
<Private>False</Private>

Assembly-CSharp.csproj

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -184,12 +184,10 @@
184184
<None Include="Assets\TextMesh Pro\Resources\LineBreaking Leading Characters.txt" />
185185
<None Include="Assets\TextMesh Pro\Shaders\TMPro_Properties.cginc" />
186186
<None Include="Assets\Amazon\Plugins\System.Buffers.xml" />
187-
<None Include="Assets\GONet\Plugins\log4net\log4net.xml" />
188187
<None Include="Assets\TextMesh Pro\Shaders\TMPro_Surface.cginc" />
189188
<None Include="Assets\Amazon\Plugins\Newtonsoft.Json.xml" />
190189
<None Include="Assets\TextMesh Pro\Resources\LineBreaking Following Characters.txt" />
191190
<None Include="Assets\StreamingAssets\GONet\Start_README.txt" />
192-
<None Include="Assets\GONet\Plugins\log4net\log4net.dll" />
193191
<None Include="Assets\Amazon\Plugins\System.Runtime.CompilerServices.Unsafe.xml" />
194192
<None Include="Assets\TextMesh Pro\Shaders\TMP_SDF-Mobile Masking.shader" />
195193
<None Include="Assets\StreamingAssets\GONet\Start_CLIENT_BAT.txt" />
@@ -543,10 +541,6 @@
543541
<HintPath>Assets\GONet\Code\Plugins\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
544542
<Private>False</Private>
545543
</Reference>
546-
<Reference Include="log4net">
547-
<HintPath>Assets\GONet\Plugins\log4net\log4net.dll</HintPath>
548-
<Private>False</Private>
549-
</Reference>
550544
<Reference Include="Newtonsoft.Json">
551545
<HintPath>Library\PackageCache\com.unity.nuget.newtonsoft-json@3.2.1\Runtime\Newtonsoft.Json.dll</HintPath>
552546
<Private>False</Private>

0 commit comments

Comments
 (0)