chore: quality-tightening (oxfmt + drop prettier/eslint + tsgo + husky self-heal) (#95)

* chore: quality-tightening (oxfmt + drop prettier/eslint + tsgo + husky self-heal)

This repo was already partially migrated (had oxlint, husky 9,
lint-staged, vitest). Finishes the alignment with the rest of the
rollout:

- prettier (root) + prettier (functions/) -> oxfmt across the workspace
- functions/ workspace eslint + @typescript-eslint/* + jest -> dropped
  entirely; the workspace now uses the root oxlint via 'yarn lint'.
- new: oxlint plugins extended to typescript + vitest + unicorn + oxc
  (was just baseline correctness rules)
- new: tsgo --noEmit as default 'typecheck'; tsc kept as
  'typecheck:tsc' fallback
- husky 9: existing /sh/ hook + 'husky install' replaced with the
  standard scripts/ensure-husky.mjs self-heal pattern + lint-staged
  + gitleaks. Drops the broken 'exec >/dev/tty' redirect that fails
  in non-interactive shells.
- npm 'shellcheck' package dropped (playbook trap #2: it's broken
  and corrupts actionlint output). mise.toml adds shellcheck plus
  actionlint and gitleaks as managed binaries.
- CI: existing main.yml steps re-ordered (Format/Lint/Typecheck/
  Test) and 'yarn format' (which writes) replaced with
  'yarn format:check' (which doesn't). codecov-action v4.0.1 -> v5.

oxlint config tunes:
- typescript/no-extraneous-class off (the codebase uses static-only
  classes as namespaces, idiomatic in this repo)
- no-await-in-loop off (Firestore migrations and rate-limited HTTP
  loops are single-threaded by design)

13 pre-existing typescript/no-explicit-any warnings remain (mostly
in firebase-functions handler signatures and json deserialisation).
Per playbook trap #22 the lint script drops --deny-warnings.

Verified locally: lint 0/13, format clean, typecheck clean, test 7/7.

* ci(versioning-backend): repair Firebase predeploy after lint migration

The Test Deploy job runs 'firebase deploy --only functions:testFunction'
which executes the firebase.json 'predeploy' hooks. The hook still
called:
  - yarn workspace functions lint
  - yarn workspace functions test run

Both broke after the migration:
- The 'lint' script is now at the root only (functions/ no longer has
  its own lint command).
- 'test run' was the jest CLI form ('jest run'); vitest's equivalent
  is 'vitest run' which we exposed as the 'test:run' workspace
  script.

Predeploy hooks now invoke:
  - yarn lint                          (root oxlint over the workspace)
  - yarn workspace functions run test:run  (vitest run, scoped to functions)
  - yarn workspace functions build      (unchanged)

Author: webbertakken

.github/workflows/main.yml

@@ -14,8 +14,7 @@ jobs:
 
       - name: Read Node version from mise.toml
         id: node
-        run:
-          echo "version=$(grep -E '^node\s*=' mise.toml | sed -E 's/.*"([^"]+)".*/\1/')" >>
+        run: echo "version=$(grep -E '^node\s*=' mise.toml | sed -E 's/.*"([^"]+)".*/\1/')" >>
           "$GITHUB_OUTPUT"
 
       - name: Install package manager (from package.json)
@@ -40,8 +39,7 @@ jobs:
             node_modules
             ${{ steps.yarn-config.outputs.cacheFolder }}
             .yarn/install-state.gz
-          key:
-            yarn-${{ runner.os }}-node${{ steps.node.outputs.version }}-${{
+          key: yarn-${{ runner.os }}-node${{ steps.node.outputs.version }}-${{
             hashFiles('yarn.lock') }}
           restore-keys: |
             yarn-${{ runner.os }}-node${{ steps.node.outputs.version }}-
@@ -53,20 +51,20 @@ jobs:
           case "$(yarn --version)" in 1.*) echo 'expected up-to-date yarn version'; exit 1 ;; esac
           yarn install --immutable
 
-      - name: run linter
-        run: yarn lint
+      - name: Format
+        run: yarn format:check
 
-      - name: run format
-        run: yarn format
+      - name: Lint
+        run: yarn lint
 
-      - name: run typecheck
+      - name: Typecheck
         run: yarn typecheck
 
-      - name: run tests
+      - name: Test
         run: yarn coverage
 
       - name: Upload coverage reports to Codecov
-        uses: codecov/codecov-action@v4.0.1
+        uses: codecov/codecov-action@v5
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           slug: game-ci/versioning-backend
@@ -82,8 +80,7 @@ jobs:
 
       - name: Read Node version from mise.toml
         id: node
-        run:
-          echo "version=$(grep -E '^node\s*=' mise.toml | sed -E 's/.*"([^"]+)".*/\1/')" >>
+        run: echo "version=$(grep -E '^node\s*=' mise.toml | sed -E 's/.*"([^"]+)".*/\1/')" >>
           "$GITHUB_OUTPUT"
 
       - name: Install package manager (from package.json)
@@ -108,8 +105,7 @@ jobs:
             node_modules
             ${{ steps.yarn-config.outputs.cacheFolder }}
             .yarn/install-state.gz
-          key:
-            yarn-${{ runner.os }}-node${{ steps.node.outputs.version }}-${{
+          key: yarn-${{ runner.os }}-node${{ steps.node.outputs.version }}-${{
             hashFiles('yarn.lock') }}
           restore-keys: |
             yarn-${{ runner.os }}-node${{ steps.node.outputs.version }}-
@@ -134,8 +130,7 @@ jobs:
 
       - name: Read Node version from mise.toml
         id: node
-        run:
-          echo "version=$(grep -E '^node\s*=' mise.toml | sed -E 's/.*"([^"]+)".*/\1/')" >>
+        run: echo "version=$(grep -E '^node\s*=' mise.toml | sed -E 's/.*"([^"]+)".*/\1/')" >>
           "$GITHUB_OUTPUT"
 
       - name: Install package manager (from package.json)
@@ -160,8 +155,7 @@ jobs:
             node_modules
             ${{ steps.yarn-config.outputs.cacheFolder }}
             .yarn/install-state.gz
-          key:
-            yarn-${{ runner.os }}-node${{ steps.node.outputs.version }}-${{
+          key: yarn-${{ runner.os }}-node${{ steps.node.outputs.version }}-${{
             hashFiles('yarn.lock') }}
           restore-keys: |
             yarn-${{ runner.os }}-node${{ steps.node.outputs.version }}-
@@ -199,8 +193,7 @@ jobs:
 
       - name: Read Node version from mise.toml
         id: node
-        run:
-          echo "version=$(grep -E '^node\s*=' mise.toml | sed -E 's/.*"([^"]+)".*/\1/')" >>
+        run: echo "version=$(grep -E '^node\s*=' mise.toml | sed -E 's/.*"([^"]+)".*/\1/')" >>
           "$GITHUB_OUTPUT"
 
       - name: Install package manager (from package.json)
@@ -225,8 +218,7 @@ jobs:
             node_modules
             ${{ steps.yarn-config.outputs.cacheFolder }}
             .yarn/install-state.gz
-          key:
-            yarn-${{ runner.os }}-node${{ steps.node.outputs.version }}-${{
+          key: yarn-${{ runner.os }}-node${{ steps.node.outputs.version }}-${{
             hashFiles('yarn.lock') }}
           restore-keys: |
             yarn-${{ runner.os }}-node${{ steps.node.outputs.version }}-

.husky/pre-commit

@@ -1,8 +1,7 @@
-#!/bin/sh
-. "$(dirname -- "$0")/_/husky.sh"
-
-# Fix from https://github.com/typicode/husky/issues/968#issuecomment-1176848345
-if [ -t 2 ] ; then exec >/dev/tty 2>&1 ; fi
-
-# Check changes that are staged for commit
+#!/usr/bin/env sh
 yarn lint-staged
+yarn typecheck
+
+if command -v gitleaks >/dev/null 2>&1; then
+  gitleaks protect --staged --no-banner --redact
+fi

.oxfmtrc.json

@@ -0,0 +1,16 @@
+{
+  "semi": true,
+  "singleQuote": true,
+  "trailingComma": "all",
+  "printWidth": 100,
+  "proseWrap": "preserve",
+  "sortPackageJson": false,
+  "ignorePatterns": [
+    "**/node_modules/**",
+    "**/lib/**",
+    "**/dist/**",
+    "**/coverage/**",
+    "**/.yarn/**",
+    "**/.firebase/**"
+  ]
+}

.oxlintrc.json

@@ -1,5 +1,43 @@
 {
+  "$schema": "./node_modules/oxlint/configuration_schema.json",
+  "plugins": ["typescript", "vitest", "unicorn", "oxc"],
+  "categories": {
+    "correctness": "error",
+    "suspicious": "error",
+    "perf": "error"
+  },
   "rules": {
-    "no-unsafe-declaration-merging": "off"
-  }
+    "vitest/require-mock-type-parameters": "off",
+    "vitest/valid-title": "off",
+    "typescript/no-explicit-any": "warn",
+    "typescript/ban-ts-comment": "off",
+    "typescript/no-namespace": "off",
+    "typescript/no-unsafe-declaration-merging": "off",
+    "typescript/no-extraneous-class": "off",
+    "no-bitwise": "off",
+    "no-await-in-loop": "off"
+  },
+  "overrides": [
+    {
+      "files": ["**/*.test.ts", "**/*.spec.ts", "**/test/**/*.ts"],
+      "rules": {
+        "typescript/no-explicit-any": "off",
+        "no-unused-vars": "off"
+      }
+    }
+  ],
+  "env": {
+    "browser": false,
+    "node": true,
+    "es2024": true,
+    "vitest/globals": true
+  },
+  "ignorePatterns": [
+    "**/node_modules/**",
+    "**/lib/**",
+    "**/dist/**",
+    "**/coverage/**",
+    "**/.yarn/**",
+    "**/.firebase/**"
+  ]
 }

.prettierignore

@@ -1,8 +1,7 @@
 nodeLinker: node-modules
 
-
 # Solo project; PRs are exclusively from the maintainer. Re-enable when
 # accepting third-party PRs that auto-trigger CI without manual review.
 enableHardenedMode: false
 
-npmRegistryServer: "https://registry.npmjs.org/"
+npmRegistryServer: 'https://registry.npmjs.org/'

.prettierrc.json

@@ -52,7 +52,6 @@ This will compile the TypeScript code into JavaScript in the `lib` directory, wh
 To use Firebase Admin SDK locally:
 
 1. Download a service account key from your Firebase project settings:
-
    - Go to [Firebase Console](https://console.firebase.google.com/)
    - Select your project
    - Go to Project Settings > Service accounts

.yarnrc.yml

@@ -6,8 +6,8 @@
   "functions": {
     "runtime": "nodejs22",
     "predeploy": [
-      "yarn workspace functions lint",
-      "yarn workspace functions test run",
+      "yarn lint",
+      "yarn workspace functions run test:run",
       "yarn workspace functions build"
     ]
   },

DEVELOPMENT.md

@@ -2,7 +2,6 @@
   "name": "functions",
   "scripts": {
     "dev": "yarn watch",
-    "lint": "eslint \"src/**/*\"",
     "build": "run -T tsc",
     "watch": "run -T tsc --watch",
     "serve": "yarn build && firebase emulators:start --only functions",
@@ -11,7 +10,8 @@
     "deploy": "firebase deploy --only functions",
     "logs": "firebase functions:log",
     "test": "run -T vitest",
-    "typecheck": "run -T tsc --noEmit",
+    "typecheck": "run -T tsgo --noEmit",
+    "typecheck:tsc": "run -T tsc --noEmit",
     "coverage": "run -T vitest run --coverage",
     "test:run": "run -T vitest run",
     "test:ui": "run -T vitest --ui"
@@ -38,12 +38,7 @@
     "@types/node-fetch": "^2.6.11",
     "@types/semver": "^7.5.8",
     "@types/ws": "^8.5.13",
-    "@typescript-eslint/eslint-plugin": "^7.12.0",
-    "@typescript-eslint/parser": "^7.12.0",
-    "eslint": "^8.57.0",
-    "eslint-plugin-import": "^2.29.1",
-    "firebase-functions-test": "^3.3.0",
-    "jest": "^29.7.0"
+    "firebase-functions-test": "^3.3.0"
   },
   "private": true,
   "packageManager": "yarn@4.14.1"