Skip to content

Commit 6cc23bb

Browse files
authored
Merge pull request #177 from Tobychev/2025-06-06
Took notes 2025-06-06 meeting
2 parents b68dcba + 038ffa5 commit 6cc23bb

File tree

1 file changed

+28
-1
lines changed

1 file changed

+28
-1
lines changed

dev-meetings/2025/2025-06-06/README.md

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,31 @@
3131
* [#5891](https://github.com/gammapy/gammapy/issues/5891) Asimov TS to Sigma conversion wrong - Stefan Fröse
3232
* [#5887](https://github.com/gammapy/gammapy/issues/5887) Make a technical tutorial about metadata handling - Bruno Khélifi
3333

34-
report created at 06/06/2025, 07:23:55
34+
# Minutes
35+
36+
* Regis presented a PR introducing a FoVFrame to simplify internal API and demonstrated how this could potentially support drift-mode observations.
37+
[#5860](https://github.com/gammapy/gammapy/pull/5860)
38+
* Kirsty opened several PRs that add docstrings to several `.run()` functions as well as improving some docs, reviews welcome.
39+
* Atreyee raised the issue that the HOWTO section is hard to navigate, some suggested solutions emerged
40+
* Remove some HOWTOS
41+
* Split up into subsections
42+
* Create a separate "Example" category
43+
* Quentin fixed a regression for Astropy 7.1, which required regenerating some test datafiles.
44+
* Kirsty provided a PR for function default labels but was not entirely happy with the solution. It was accepted as good enough for now, but a porper plotting class could be created in the future.
45+
* Samantha will present the Veritas gammapy tutorial next week.
46+
47+
## Upper limit calculations
48+
Samantha Wong and Matthew Lundy has had problems getting upper limits when trying to place differential limits on what is likely empty fields, the issue arises when the excess happens to be negative. In that case the reference flux calculated is negative which breaks hardcoded assumptions and limits aren't produced.
49+
50+
It is somewhat surprising that this issue has not been highligted previously, it could be because Veritas is trying to use gammapy for all analysis while in other experiments it as been applied mainly to fields where there is some signal.
51+
52+
Discussion on how to handle it produces two suggestions
53+
* Emit a warning whenever the reference model has a negative norm to let the user know they need to make a choice
54+
* Update the code so it produces upper limits also when the norm is negative (even if this is perhaps not the most apropriate Upper Limit)
55+
56+
## Workflow step PR
57+
The analysis class is being refactored into a workflow composed of several steps, hopefully this will allow for more parallelism.
58+
59+
The PR [#5900](https://github.com/gammapy/gammapy/issues/5900) introduces a `Product` class to store intermediate results in the steps instead of storing them inside the worflow class, making for looser coupling easing paralell execution of separate steps.
60+
61+
This work will now be split into several smaller PRs because the current one is a bit hard to follow.

0 commit comments

Comments
 (0)