Fixed the sync, added a test to cover the issue

Author: gandazgul

playwright/app.spec.js

@@ -107,6 +107,17 @@ test.describe("Goaly App", () => {
     await expect(page.getByRole("heading", { name: "Your Active Goals" }))
       .toBeVisible();
 
+    // Create a goal first so that there are instances to delete during sync
+    await page.getByRole("button", { name: "Add Goal" }).click();
+    await expect(page.getByRole("heading", { name: "New Goal" })).toBeVisible();
+
+    const testGoalName = `Sync Test Goal ${Date.now()}`;
+    await page.getByRole("textbox", { name: "I want to..." }).fill(testGoalName);
+    await page.locator("label").filter({ hasText: "Morning 6am - 12pm" }).click();
+    await page.getByRole("button", { name: "Save Goal" }).click();
+
+    await expect(page.getByRole("heading", { name: testGoalName })).toBeVisible();
+
     page.once("dialog", (dialog) => {
       dialog.accept().catch(() => {});
     });
@@ -119,6 +130,12 @@ test.describe("Goaly App", () => {
     await expect(
       page.getByText("Your goals have been re-scheduled into your calendar."),
     ).toBeVisible();
+
+    // Clean up
+    page.on("dialog", (dialog) => dialog.accept());
+    await page.locator("details", { hasText: testGoalName }).getByRole("heading", { name: testGoalName }).click();
+    await page.locator("details", { hasText: testGoalName }).getByRole("button", { name: "Delete Goal" }).click();
+    await expect(page.getByRole("heading", { name: testGoalName })).not.toBeVisible();
   });
 
   test("should allow user to logout", async ({ page }) => {

src/pages/api/goals/sync.js

@@ -36,14 +36,16 @@ export const POST = async ({ request, redirect }) => {
     // Delete these instances from the DB
     if (futureInstances.length > 0) {
       const deleteStmt = db.prepare("DELETE FROM goal_instances WHERE id = ?");
-      const deleteTransaction = db.transaction(
-        (/** @type {any[]} */ instances) => {
-          for (const instance of instances) {
-            deleteStmt.run(instance.id);
-          }
-        },
-      );
-      deleteTransaction(futureInstances);
+      db.exec("BEGIN TRANSACTION;");
+      try {
+        for (const instance of futureInstances) {
+          deleteStmt.run(instance.id);
+        }
+        db.exec("COMMIT;");
+      } catch (err) {
+        db.exec("ROLLBACK;");
+        throw err;
+      }
     }
 
     // 2. Re-schedule phase: Fetch goals ordered by duration (shortest first)