Skip to content

Commit b5e99ed

Browse files
committed
Remove LOCATION_FUNC
Also tweak PrintKernelFunction
1 parent 07f584b commit b5e99ed

4 files changed

Lines changed: 8 additions & 32 deletions

File tree

lib/function.g

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -347,13 +347,6 @@ BIND_GLOBAL( "LocationFunc", function(func)
347347
APPEND_LIST(ret, STRING_INT(line));
348348
return ret;
349349
fi;
350-
line := LOCATION_FUNC(func);
351-
if line <> fail then
352-
APPEND_LIST(ret, nam);
353-
APPEND_LIST(ret, ":");
354-
APPEND_LIST(ret, line);
355-
return ret;
356-
fi;
357350
return fail;
358351
end);
359352

src/calls.c

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1347,11 +1347,8 @@ void PrintKernelFunction(Obj func)
13471347
Pr("<<compiled GAP code>> from %g:%d", (Int)filename,
13481348
startline);
13491349
}
1350-
else if (location != Fail) {
1351-
Pr("<<kernel code>> from %g:%g", (Int)filename, (Int)location);
1352-
}
13531350
else {
1354-
Pr("<<kernel or compiled code>>", 0, 0);
1351+
Pr("<<kernel or compiled code>> from %g", (Int)filename, 0);
13551352
}
13561353
}
13571354
else {
@@ -1731,13 +1728,6 @@ static Obj FuncENDLINE_FUNC(Obj self, Obj func)
17311728
return Fail;
17321729
}
17331730

1734-
static Obj FuncLOCATION_FUNC(Obj self, Obj func)
1735-
{
1736-
RequireFunction(SELF_NAME, func);
1737-
1738-
return IsKernelFunction(func) ? KernelLocationOfFunction(func) : Fail;
1739-
}
1740-
17411731
/****************************************************************************
17421732
**
17431733
*F FuncUNPROFILE_FUNC( <self>, <func> ) . . . . . . . . . . . stop profile
@@ -1955,7 +1945,6 @@ static StructGVarFunc GVarFuncs[] = {
19551945
GVAR_FUNC_1ARGS(UNPROFILE_FUNC, func),
19561946
GVAR_FUNC_1ARGS(IsKernelFunction, func),
19571947
GVAR_FUNC_1ARGS(FILENAME_FUNC, func),
1958-
GVAR_FUNC_1ARGS(LOCATION_FUNC, func),
19591948
GVAR_FUNC_1ARGS(STARTLINE_FUNC, func),
19601949
GVAR_FUNC_1ARGS(ENDLINE_FUNC, func),
19611950

tst/testinstall/declarefunction.tst

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ gap> testfunctionA;
99
function( args... ) ... end
1010
gap> Print(testfunctionA,"\n");
1111
function ( args... )
12-
<<kernel code>> from the global function "testfunctionA" is not yet define\
13-
d:
12+
<<kernel or compiled code>> from the global function "testfunctionA" is no\
13+
t yet defined
1414
end
1515
gap> InstallGlobalFunction(testfunctionA, x -> x);
1616
gap> testfunctionA;
@@ -23,15 +23,15 @@ gap> name := List([1..100], x -> 'a');;
2323
gap> func := NEW_GLOBAL_FUNCTION(name);;
2424
gap> Print(func,"\n");
2525
function ( args... )
26-
<<kernel code>> from the global function "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\
27-
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" is not y\
28-
et defined:
26+
<<kernel or compiled code>> from the global function "aaaaaaaaaaaaaaaaaaaa\
27+
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\
28+
aa" is not yet defined
2929
end
3030
gap> name := List([1..1000], x -> 'a');;
3131
gap> func := NEW_GLOBAL_FUNCTION(name);;
3232
gap> Print(func,"\n");
3333
function ( args... )
34-
<<kernel code>> from the global function "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\
34+
<<kernel or compiled code>> from the global function "aaaaaaaaaaaaaaaaaaaa\
3535
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\
3636
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\
3737
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\
@@ -44,6 +44,6 @@ aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\
4444
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\
4545
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\
4646
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\
47-
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" is not yet defined:
47+
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" is not yet defined
4848
end
4949
gap> STOP_TEST("declarefunction.tst");

tst/testinstall/kernel/calls.tst

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,12 +111,6 @@ gap> ENDLINE_FUNC(f);
111111
1
112112
gap> ENDLINE_FUNC(IS_OBJECT);
113113
fail
114-
gap> LOCATION_FUNC(fail);
115-
Error, LOCATION_FUNC: <func> must be a function (not the value 'fail')
116-
gap> LOCATION_FUNC(f);
117-
fail
118-
gap> LOCATION_FUNC(IS_OBJECT);
119-
fail
120114
121115
#
122116
gap> UNPROFILE_FUNC(fail);

0 commit comments

Comments
 (0)