Fix auto-leave-on-end: true error.

The ConcurrentModificationException happens because the player leave
procedure alters the `specPlayers` set, and this is the set we iterate
during the automatic spectator kicking procedure. By making a copy of
the set and iterating the copy, we circumvent this problem. Java 101,
really, but when the code is stateful and complex, it's "fair enough"
that it slipped through the cracks. It's also impossible to reproduce
without at least two players, so go figure...

Fixes #802

Author: garbagemule

changelog.md

@@ -24,6 +24,7 @@ These changes will (most likely) be included in the next version.
 
 ### Fixed
 - MobArena no longer throws errors when handling block explosions on Minecraft 1.21.
+- MobArena no longer throws errors during the automatic removal of spectators when using `auto-leave-on-end: true`.
 - The `shuffle-positions` ability now correctly shuffles the position of the boss as well if `monster-teleport` is set to `false`.
 - The `obsidian-bomb` ability no longer breaks boss waves.
 - Text on Arena Signs is no longer explicitly truncated. This fixes an issue where color codes would count towards the character limit, causing the text that would otherwise fit on the sign to be cut off.

src/main/java/com/garbagemule/MobArena/ArenaImpl.java

@@ -665,7 +665,8 @@ public boolean endArena() {
 
         // Auto-leave
         if (settings.getBoolean("auto-leave-on-end", false)) {
-            specPlayers.forEach(this::playerLeave);
+            List<Player> spectators = new ArrayList<>(specPlayers);
+            spectators.forEach(this::playerLeave);
         }
 
         return true;