Skip to content

Commit 6bfce09

Browse files
VelocityRaafedchin
andcommitted
rp/renderin/dx: Fix thumbnail rendering order bug
Thanks to @afedchin for figuring this out! Co-authored-by: Anton Fedchin <[email protected]>
1 parent 6de89f5 commit 6bfce09

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

xbmc/cores/RetroPlayer/rendering/VideoShaders/windows/VideoShaderPresetDX.cpp

+10-10
Original file line numberDiff line numberDiff line change
@@ -424,16 +424,6 @@ bool CVideoShaderPresetDX::CreateBuffers()
424424

425425
void CVideoShaderPresetDX::PrepareParameters(const IShaderTexture* texture, const CPoint dest[])
426426
{
427-
// prepare params for all shaders except the last (needs special flag)
428-
for (unsigned shaderIdx = 0; shaderIdx < m_pVideoShaders.size() - 1; ++shaderIdx)
429-
{
430-
auto& videoShader = m_pVideoShaders[shaderIdx];
431-
videoShader->PrepareParameters(m_dest, false, m_frameCount);
432-
}
433-
434-
// prepare params for last shader
435-
m_pVideoShaders.back()->PrepareParameters(m_dest, true, m_frameCount);
436-
437427
if (m_dest[0] != dest[0] || m_dest[1] != dest[1]
438428
|| m_dest[2] != dest[2] || m_dest[3] != dest[3]
439429
|| texture->GetWidth() != m_outputSize.x
@@ -448,6 +438,16 @@ void CVideoShaderPresetDX::PrepareParameters(const IShaderTexture* texture, cons
448438
UpdateMVPs();
449439
UpdateViewPort();
450440
}
441+
442+
// prepare params for all shaders except the last (needs special flag)
443+
for (unsigned shaderIdx = 0; shaderIdx < m_pVideoShaders.size() - 1; ++shaderIdx)
444+
{
445+
auto& videoShader = m_pVideoShaders[shaderIdx];
446+
videoShader->PrepareParameters(m_dest, false, m_frameCount);
447+
}
448+
449+
// prepare params for last shader
450+
m_pVideoShaders.back()->PrepareParameters(m_dest, true, m_frameCount);
451451
}
452452

453453
bool CVideoShaderPresetDX::HasPathFailed(const std::string& path) const

0 commit comments

Comments
 (0)