Proposal for disabling terminal scheduling on non-managed seeds

Author: grolu

frontend/src/components/GTerminalSettings.vue

@@ -26,11 +26,21 @@ SPDX-License-Identifier: Apache-2.0
         hint="Choose "Cluster" if you want to troubleshoot a worker node of the cluster"
         persistent-hint
       >
-        <v-radio
-          label="Infrastructure (Seed)"
-          value="seed"
-          color="primary"
-        />
+        <div>
+          <v-radio
+            label="Infrastructure (Seed)"
+            value="seed"
+            color="primary"
+            :disabled="!canScheduleOnSeed"
+          />
+          <v-tooltip
+            activator="parent"
+            location="top left"
+            :disabled="canScheduleOnSeed"
+          >
+            Terminals can only be scheduled on managed seeds
+          </v-tooltip>
+        </div>
         <v-radio
           label="Cluster"
           value="shoot"
@@ -133,6 +143,7 @@ export default {
       shootNodes,
       privilegedMode,
       runtime,
+      canScheduleOnSeed,
     } = toRefs(state)
 
     const rules = {
@@ -148,6 +159,7 @@ export default {
       shootNodes,
       privilegedMode,
       runtime,
+      canScheduleOnSeed,
     }
   },
   computed: {

frontend/src/components/GTerminalTarget.vue

@@ -13,12 +13,22 @@ SPDX-License-Identifier: Apache-2.0
       :hint="hint"
       persistent-hint
     >
-      <v-radio
-        v-if="shootItem && hasControlPlaneTerminalAccess"
-        label="Control Plane"
-        value="cp"
-        color="primary"
-      />
+      <div>
+        <v-radio
+          v-if="shootItem && hasControlPlaneTerminalAccess"
+          label="Control Plane"
+          value="cp"
+          color="primary"
+          :disabled="!canScheduleOnSeed"
+        />
+        <v-tooltip
+          activator="parent"
+          location="top left"
+          :disabled="canScheduleOnSeed"
+        >
+          Terminals can only be scheduled on managed seeds
+        </v-tooltip>
+      </div>
       <v-radio
         v-if="shootItem && hasShootTerminalAccess"
         value="shoot"
@@ -84,12 +94,14 @@ export default {
     const {
       shootItem,
       isShootStatusHibernated,
+      canScheduleOnSeed,
     } = useTerminalSplitpanes()
 
     return {
       v$: useVuelidate(),
       shootItem,
       isShootStatusHibernated,
+      canScheduleOnSeed,
     }
   },
   validations () {

frontend/src/components/ShootDetails/GShootAccessCard.vue

@@ -236,7 +236,7 @@ const isTerminalTileVisible = computed(() => {
 })
 
 const isTerminalShortcutsTileVisible = computed(() => {
-  return isTerminalShortcutsFeatureEnabled.value  && !hideTerminalShortcuts.value && isTerminalShortcutsFeatureEnabled.value
+  return isTerminalShortcutsFeatureEnabled.value && !hideTerminalShortcuts.value && isTerminalShortcutsFeatureEnabled.value
 })
 
 function onAddTerminalShortcut (shortcut) {

frontend/src/components/dialogs/GCreateTerminalSessionDialog.vue

@@ -164,6 +164,7 @@ export default {
       shootName,
       hasShootWorkerGroups,
       isShootStatusHibernated,
+      canScheduleOnSeed,
       newTerminalPrompt,
       defaultTarget,
       setSelections,
@@ -181,6 +182,7 @@ export default {
       shootName,
       hasShootWorkerGroups,
       isShootStatusHibernated,
+      canScheduleOnSeed,
       newTerminalPrompt,
       defaultTarget,
       setSelections,
@@ -275,6 +277,10 @@ export default {
         await this.promptForSelections()
       }
     },
+    defaultTarget (value) {
+      this.targetTab.selectedTarget = value
+      this.updateSettings()
+    },
   },
   methods: {
     async promptForSelections () {
@@ -345,6 +351,8 @@ export default {
           name: this.shootName,
           target: this.targetTab.selectedTarget,
         })
+        config.canScheduleOnSeed = this.canScheduleOnSeed
+
         this.updateState(config)
       } catch (err) {
         this.targetTab.initializedForTarget = undefined

frontend/src/composables/useTerminalConfig.js

@@ -28,6 +28,7 @@ export function createTerminalConfigComposable () {
       currentNode,
       privilegedMode,
       nodes = [],
+      canScheduleOnSeed = false,
     } = options
 
     const autoSelectNodeItem = {
@@ -37,13 +38,13 @@ export function createTerminalConfigComposable () {
     }
 
     state.node = defaultNode
-    if (!defaultNode) {
+    if (!defaultNode && nodes.length) {
       state.node = authnStore.isAdmin
         ? get(head(nodes), ['data', 'kubernetesHostname'])
         : autoSelectNodeItem.data.kubernetesHostname
     }
 
-    if (!authnStore.isAdmin) {
+    if (!authnStore.isAdmin || !canScheduleOnSeed) {
       state.runtime = 'shoot'
     } else {
       const currentNodeIsShootWorker = some(nodes, ['data.kubernetesHostname', currentNode])
@@ -56,6 +57,7 @@ export function createTerminalConfigComposable () {
     if (nodes.length) {
       state.shootNodes.unshift(autoSelectNodeItem)
     }
+    state.canScheduleOnSeed = canScheduleOnSeed
   }
 
   const state = reactive({
@@ -94,6 +96,9 @@ export function createTerminalConfigComposable () {
     if (authnStore.isAdmin) {
       state.privilegedMode = value === 'shoot'
     }
+    if (!state.canScheduleOnSeed) {
+      state.privilegedMode = false
+    }
   })
 
   return {

frontend/src/composables/useTerminalSplitpanes.js

@@ -86,13 +86,21 @@ export function createTerminalSplitpanesComposable () {
     return isStatusHibernated(get(shootItem.value, ['status']))
   })
 
+  const canScheduleOnSeed = computed(() => {
+    return get(shootItem.value, ['info', 'canLinkToSeed'])
+  })
+
   const slotItemUUIds = computed(() => {
     const slotItems = filter(symbolTree.items(), ['data.type', 'SLOT_ITEM'])
     return map(slotItems, 'uuid')
   })
 
   const defaultTarget = computed(() => {
-    return terminalCoordinates.value.target || (authzStore.hasControlPlaneTerminalAccess ? TargetEnum.CONTROL_PLANE : TargetEnum.SHOOT)
+    return terminalCoordinates.value.target ||
+     (authzStore.hasControlPlaneTerminalAccess &&
+      canScheduleOnSeed.value)
+      ? TargetEnum.CONTROL_PLANE
+      : TargetEnum.SHOOT
   })
 
   function addSlotItem ({ data = {}, targetId, position } = {}) {
@@ -250,6 +258,7 @@ export function createTerminalSplitpanesComposable () {
     shootName,
     hasShootWorkerGroups,
     isShootStatusHibernated,
+    canScheduleOnSeed,
     splitpaneTree,
     newTerminalPrompt,
     defaultTarget,