Set the default snapshot compression to true. (#1202)

Author: ishan16696

api/core/v1alpha1/etcd.go

@@ -31,7 +31,7 @@ const (
 	// DefaultCompression is constant for default compression policy(only if compression is enabled).
 	DefaultCompression = GzipCompression
 	// DefaultCompressionEnabled is constant to define whether to compress the snapshots or not.
-	DefaultCompressionEnabled = false
+	DefaultCompressionEnabled bool = true
 
 	// Periodic is a constant to set auto-compaction-mode 'periodic' for duration based retention.
 	Periodic CompactionMode = "periodic"

examples/etcd/druid_v1alpha1_etcd.yaml

@@ -54,7 +54,7 @@ spec:
     #   provider: local # options: aws,azure,gcp,openstack,alicloud,dell,openshift,local
     #   prefix: etcd-test
     compression:
-      enabled: false
+      enabled: true # false (to disable compression)
       policy: "gzip"
     leaderElection:
       reelectionPeriod: 5s

examples/etcd/druid_v1alpha1_etcd_azurite.yaml

@@ -54,7 +54,7 @@ spec:
       secretRef:
         name: etcd-backup-azurite
     compression:
-      enabled: false
+      enabled: true
       policy: "gzip"
     leaderElection:
       reelectionPeriod: 5s

examples/etcd/druid_v1alpha1_etcd_fakegcs.yaml

@@ -54,7 +54,7 @@ spec:
       secretRef:
         name: etcd-backup-gcp
     compression:
-      enabled: false
+      enabled: true
       policy: "gzip"
     leaderElection:
       reelectionPeriod: 5s

examples/etcd/druid_v1alpha1_etcd_localstack.yaml

@@ -54,7 +54,7 @@ spec:
       secretRef:
         name: etcd-backup-aws
     compression:
-      enabled: false
+      enabled: true
       policy: "gzip"
     leaderElection:
       reelectionPeriod: 5s

internal/component/statefulset/builder.go

@@ -565,15 +565,15 @@ func (b *stsBuilder) getBackupStoreCommandArgs() []string {
 
 	// Snapshot compression and timeout command line args
 	// -----------------------------------------------------------------------------------------------------------------
+	compressionEnabled, compressionPolicy := druidv1alpha1.DefaultCompressionEnabled, druidv1alpha1.DefaultCompression
 	if b.etcd.Spec.Backup.SnapshotCompression != nil {
-		if ptr.Deref(b.etcd.Spec.Backup.SnapshotCompression.Enabled, false) {
-			commandArgs = append(commandArgs, fmt.Sprintf("--compress-snapshots=%t", *b.etcd.Spec.Backup.SnapshotCompression.Enabled))
-		}
-		if b.etcd.Spec.Backup.SnapshotCompression.Policy != nil {
-			commandArgs = append(commandArgs, fmt.Sprintf("--compression-policy=%s", string(*b.etcd.Spec.Backup.SnapshotCompression.Policy)))
-		}
+		compressionEnabled = ptr.Deref(b.etcd.Spec.Backup.SnapshotCompression.Enabled, druidv1alpha1.DefaultCompressionEnabled)
+		compressionPolicy = ptr.Deref(b.etcd.Spec.Backup.SnapshotCompression.Policy, druidv1alpha1.DefaultCompression)
 	}
 
+	commandArgs = append(commandArgs, fmt.Sprintf("--compress-snapshots=%t", compressionEnabled))
+	commandArgs = append(commandArgs, fmt.Sprintf("--compression-policy=%s", compressionPolicy))
+
 	etcdSnapshotTimeout := defaultEtcdSnapshotTimeout
 	if b.etcd.Spec.Backup.EtcdSnapshotTimeout != nil {
 		etcdSnapshotTimeout = b.etcd.Spec.Backup.EtcdSnapshotTimeout.Duration.String()