implement correct interface (#1713)

kon-angelo · web-flow · commit c73cf0b037ef · 2026-02-25T09:59:36.000Z
diff --git a/pkg/controller/healthcheck/customroutecontrollerhealth.go b/pkg/controller/healthcheck/customroutecontrollerhealth.go
@@ -92,15 +92,15 @@ func (hc *CustomRouteControllerHealthCheck) SetLoggerSuffix(provider, extension
 	hc.deploymentCheck.SetLoggerSuffix(provider, extension)
 }
 
-// InjectSeedClient injects the seed client
-func (hc *CustomRouteControllerHealthCheck) InjectSeedClient(seedClient client.Client) {
+// InjectSourceClient injects the seed client into the health check and also into the underlying deployment health check.
+func (hc *CustomRouteControllerHealthCheck) InjectSourceClient(seedClient client.Client) {
 	if itf, ok := hc.deploymentCheck.(healthcheck.SourceClient); ok {
 		itf.InjectSourceClient(seedClient)
 	}
 }
 
-// InjectShootClient injects the shoot client
-func (hc *CustomRouteControllerHealthCheck) InjectShootClient(shootClient client.Client) {
+// InjectTargetClient injects the shoot client into the health check and also into the underlying deployment health check.
+func (hc *CustomRouteControllerHealthCheck) InjectTargetClient(shootClient client.Client) {
 	if itf, ok := hc.deploymentCheck.(healthcheck.TargetClient); ok {
 		itf.InjectTargetClient(shootClient)
 	}
diff --git a/pkg/controller/healthcheck/customroutecontrollerhealth_test.go b/pkg/controller/healthcheck/customroutecontrollerhealth_test.go
@@ -143,7 +143,7 @@ func runHealthCheckWithEvent(event *corev1.Event, scheme *runtime.Scheme) (*heal
 	}
 
 	hc := chealthcheck.NewCustomRouteControllerHealthCheck(deploymentCheck)
-	hc.InjectShootClient(shootClient)
+	hc.InjectTargetClient(shootClient)
 	hc.Logger = logr.Discard()
 
 	return hc.Check(context.Background(), types.NamespacedName{

Original file line number	Diff line number	Diff line change
`@@ -92,15 +92,15 @@ func (hc *CustomRouteControllerHealthCheck) SetLoggerSuffix(provider, extension`
`92`	`92`	`hc.deploymentCheck.SetLoggerSuffix(provider, extension)`
`93`	`93`	`}`
`94`	`94`
`95`		`-// InjectSeedClient injects the seed client`
`96`		`-func (hc *CustomRouteControllerHealthCheck) InjectSeedClient(seedClient client.Client) {`
	`95`	`+// InjectSourceClient injects the seed client into the health check and also into the underlying deployment health check.`
	`96`	`+func (hc *CustomRouteControllerHealthCheck) InjectSourceClient(seedClient client.Client) {`
`97`	`97`	`if itf, ok := hc.deploymentCheck.(healthcheck.SourceClient); ok {`
`98`	`98`	`itf.InjectSourceClient(seedClient)`
`99`	`99`	`}`
`100`	`100`	`}`
`101`	`101`
`102`		`-// InjectShootClient injects the shoot client`
`103`		`-func (hc *CustomRouteControllerHealthCheck) InjectShootClient(shootClient client.Client) {`
	`102`	`+// InjectTargetClient injects the shoot client into the health check and also into the underlying deployment health check.`
	`103`	`+func (hc *CustomRouteControllerHealthCheck) InjectTargetClient(shootClient client.Client) {`
`104`	`104`	`if itf, ok := hc.deploymentCheck.(healthcheck.TargetClient); ok {`
`105`	`105`	`itf.InjectTargetClient(shootClient)`
`106`	`106`	`}`
Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ func runHealthCheckWithEvent(event corev1.Event, scheme runtime.Scheme) (*heal`
`143`	`143`	`}`
`144`	`144`
`145`	`145`	`hc := chealthcheck.NewCustomRouteControllerHealthCheck(deploymentCheck)`
`146`		`- hc.InjectShootClient(shootClient)`
	`146`	`+ hc.InjectTargetClient(shootClient)`
`147`	`147`	`hc.Logger = logr.Discard()`
`148`	`148`
`149`	`149`	`return hc.Check(context.Background(), types.NamespacedName{`