fix lint checks

Author: DockToFuture

pkg/apis/config/install/install.go

@@ -8,6 +8,7 @@ package install
 
 import (
 	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apimachinery/pkg/runtime/schema"
 	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
 
 	"github.com/gardener/gardener-extension-shoot-traefik/pkg/apis/config"
@@ -17,6 +18,6 @@ import (
 // Install registers the API group and adds types to a scheme
 func Install(scheme *runtime.Scheme) {
 	utilruntime.Must(config.AddToScheme(scheme))
-	utilruntime.Must(v1alpha1.AddToScheme(scheme))
-	utilruntime.Must(scheme.SetVersionPriority(v1alpha1.SchemeGroupVersion))
+	utilruntime.Must(v1alpha1.Install(scheme))
+	utilruntime.Must(scheme.SetVersionPriority(schema.GroupVersion(v1alpha1.GroupVersion)))
 }

pkg/traefik/deployer.go

@@ -61,7 +61,7 @@ type Deployer struct {
 }
 
 // NewDeployer creates a new Deployer.
-func NewDeployer(c client.Client, logger logr.Logger, config Config, imageVector imagevector.ImageVector) *Deployer {
+func NewDeployer(c client.Client, logger logr.Logger, cfg Config, imageVector imagevector.ImageVector) *Deployer {
 	scheme := runtime.NewScheme()
 	_ = corev1.AddToScheme(scheme)
 	_ = appsv1.AddToScheme(scheme)
@@ -72,7 +72,7 @@ func NewDeployer(c client.Client, logger logr.Logger, config Config, imageVector
 		client:      c,
 		decoder:     serializer.NewCodecFactory(scheme).UniversalDecoder(),
 		logger:      logger.WithName("traefik-deployer"),
-		config:      config,
+		config:      cfg,
 		imageVector: imageVector,
 	}
 }

pkg/traefik/deployer_test.go

@@ -5,6 +5,7 @@
 package traefik
 
 import (
+	"slices"
 	"strings"
 	"testing"
 
@@ -213,14 +214,7 @@ func TestDeployment_IngressProvider(t *testing.T) {
 
 			// Check expected args are present
 			for _, expectedArg := range tt.expectedArgs {
-				found := false
-				for _, arg := range args {
-					if arg == expectedArg {
-						found = true
-						break
-					}
-				}
-				if !found {
+				if !slices.Contains(args, expectedArg) {
 					t.Errorf("expected arg %q not found in deployment args: %v", expectedArg, args)
 				}
 			}
@@ -243,14 +237,7 @@ func TestDeployment_IngressProvider(t *testing.T) {
 				"--entrypoints.websecure.address=:8443",
 			}
 			for _, commonArg := range commonArgs {
-				found := false
-				for _, arg := range args {
-					if arg == commonArg {
-						found = true
-						break
-					}
-				}
-				if !found {
+				if !slices.Contains(args, commonArg) {
 					t.Errorf("common arg %q not found in deployment args: %v", commonArg, args)
 				}
 			}
@@ -303,27 +290,16 @@ func TestClusterRole_RBAC_Permissions(t *testing.T) {
 			// Check for namespace permissions
 			hasNamespacePerms := false
 			for _, rule := range clusterRole.Rules {
-				for _, resource := range rule.Resources {
-					if resource == "namespaces" {
-						hasNamespacePerms = true
-						// Verify the permissions are correct
-						expectedVerbs := []string{"get", "list", "watch"}
-						for _, verb := range expectedVerbs {
-							found := false
-							for _, v := range rule.Verbs {
-								if v == verb {
-									found = true
-									break
-								}
-							}
-							if !found {
-								t.Errorf("expected verb %q for namespaces resource not found", verb)
-							}
+				if slices.Contains(rule.Resources, "namespaces") {
+					hasNamespacePerms = true
+					// Verify the permissions are correct
+					expectedVerbs := []string{"get", "list", "watch"}
+					for _, verb := range expectedVerbs {
+						if !slices.Contains(rule.Verbs, verb) {
+							t.Errorf("expected verb %q for namespaces resource not found", verb)
 						}
-						break
 					}
-				}
-				if hasNamespacePerms {
+
 					break
 				}
 			}
@@ -347,23 +323,15 @@ func TestClusterRole_RBAC_Permissions(t *testing.T) {
 			for resource, expectedVerbs := range commonResources {
 				found := false
 				for _, rule := range clusterRole.Rules {
-					for _, res := range rule.Resources {
-						if res == resource {
-							found = true
-							for _, verb := range expectedVerbs {
-								verbFound := false
-								for _, v := range rule.Verbs {
-									if v == verb {
-										verbFound = true
-										break
-									}
-								}
-								if !verbFound {
-									t.Errorf("expected verb %q for resource %q not found", verb, resource)
-								}
+					if slices.Contains(rule.Resources, resource) {
+						found = true
+						for _, verb := range expectedVerbs {
+							if !slices.Contains(rule.Verbs, verb) {
+								t.Errorf("expected verb %q for resource %q not found", verb, resource)
 							}
-							break
 						}
+
+						break
 					}
 				}
 				if !found {