make verify failes locally

[RAPSNX]

How to categorize this issue?

/area dev-productivity
/kind bug

What happened:

make verify failes locally with:

Error: build linters: unable to load custom analyzer "logcheck": hack/tools/bin/linux-amd64/logcheck.so, plugin.Open("/home/rapsn/Projects/gardener/gardener/hack/tools/bin/linux-amd64/logcheck"): plugin was built with a different version of package internal/godebugs
The command is terminated due to an error: build linters: unable to load custom analyzer "logcheck": hack/tools/bin/linux-amd64/logcheck.so, plugin.Open("/home/rapsn/Projects/gardener/gardener/hack/tools/bin/linux-amd64/logcheck"): plugin was built with a different version of package internal/godebugs

This issue already existed before: #9453

The problem is that the logcheck module is out-of-sync with the gardener module version.

gardener/hack/tools/logcheck/go.mod

Line 4 in d6effc0

go 1.25.0

This mismatches with the actual go 1.25.6 of g/g.
Manually bumping the version fixes the issue.

How to reproduce it (as minimally and precisely as possible):

make verify or make check

Anything else we need to know?:

Not sure if #13545 would address this issue?
@maboehm?

Environment:

• Gardener version:
• Kubernetes version (use kubectl version):
• Cloud provider or hardware configuration:
• Others:

[acumino]

The problem is that the logcheck module is out-of-sync with the gardener module version.

@RAPSNX The go version needs to be in sync with golangci-lint not gardener module.

Can you try running make clean-tools-bin to remove any faulty builds and then run the command again?

[RAPSNX]

Can you try running make clean-tools-bin to remove any faulty builds and then run the command again?

I did, I can observe that it downloads the log module freshly. But still same issue.

[acumino]

Are u using the current master branch? I tried it locally and it works fine.

[Kumm-Kai]

I'm having the same issue, maybe it's also just a quirk with my setup.

hack/tools/bin/linux-amd64/golangci-lint --version shows:

golangci-lint has version 2.10.1 built with go1.25.6 from (unknown, modified: ?, mod sum: "h1:flhw5Px6ojbLyEFzXvJn5B2HEdkkRlkhE1SnmCbQBiE=") on (unknown)

But the upstream golangci-lint go.mod and the hack/tools/logcheck/go.mod also has 1.25.0.

When changing the main go.mod from 1.25.6 to e.g., 1.25.5 then running make clean-tools-bin and then rerunning make check, hack/tools/bin/linux-amd64/golangci-lint --version gives 1.25.5.

When the hack/tools/logcheck/go.mod has the same go version as we build golangci-lint with, then it works.

Both @RAPSNX and I are running ubuntu.

[Kumm-Kai]

@acumino we've found the root cause.
Locally I have go 1.25.5, the main go.mod has 1.25.6.

In hack/tools.mk golangci-lint is built relative to the repository root, so it will use 1.25.6. logcheck however, is build relative to hack/tools/logcheck which has 1.25.0 in it's go.mod. This results in it being built with the latest locally available go toolchain, so 1.25.5.

I've verified it with go version -m hack/tools/bin/linux-amd64/golangci-lint and go version -m hack/tools/bin/linux-amd64/logcheck.so

The proper fix would be to change the hack/tools.mk like this:

diff --git a/hack/tools.mk b/hack/tools.mk
index 8536105343..8debed33e9 100644
--- a/hack/tools.mk
+++ b/hack/tools.mk
@@ -163,7 +163,7 @@ $(GOIMPORTSREVISER): $(call tool_version_file,$(GOIMPORTSREVISER),$(GOIMPORTSREV
 $(GOLANGCI_LINT): $(call tool_version_file,$(GOLANGCI_LINT),$(GOLANGCI_LINT_VERSION))
 	@# CGO_ENABLED has to be set to 1 in order for golangci-lint to be able to load plugins
 	@# see https://github.com/golangci/golangci-lint/issues/1276
-	GOBIN=$(abspath $(TOOLS_BIN_DIR)) CGO_ENABLED=1 go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@$(GOLANGCI_LINT_VERSION)
+	cd $(TOOLS_PKG_PATH)/logcheck;GOBIN=$(abspath $(TOOLS_BIN_DIR)) CGO_ENABLED=1 go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@$(GOLANGCI_LINT_VERSION)
 
 $(GOSEC): $(call tool_version_file,$(GOSEC),$(GOSEC_VERSION))
 	@GOSEC_VERSION=$(GOSEC_VERSION) bash $(TOOLS_PKG_PATH)/install-gosec.sh

This results in golangci-lint being built with 1.25.5, just like logcheck 🙂

[shafeeqes]

Sounds good. Would you like to open a fix?

[Kumm-Kai]

Thanks for the feedback. I'll open a PR 🙂