Skip to content

Refactor github/__main__.py to conform with the style of the rest of the project #189

@vivus-ignis

Description

@vivus-ignis

What would you like to be added:

  • OOP style for the code in github module

Why is this needed:

Suggestions from @NotTheEvilOne:

  • do not use s3_artifacts._bucket property, use bucket (without underscore) instead
  • add support for semantic versioning
  • use commit_id parameter for CName constructor
  • make github module and FlavorsParser behavior consistent with regards of what flavors.yaml they're using

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions