hook command failure doesn't trigger second hook

[eleith]

description / reproduction

i have two hooks.

hook A: a command hook, triggering on CONDITION_SNAPSHOT_START and error behavior set to ON_ERROR_FATAL

hook B: a notification hook triggering on CONDITION_ANY_ERROR

however, when hook A fails, hook B is not triggered.

Expected behavior

i expect hook B to trigger a notification when any error occurs with a snapshot, including hooks that run when a snapshot is started.

Platform Info

• Backrest Version 1.8.0

Additional context

perhaps this is a feature request and not a bug?

however, because hook A is triggered before a snapshot is run and the error behavior causes the snapshot to never run, my expectation is that my notification would let me about the fatal outcome.

[garethgeorge]

Notes for myself: https://github.com/garethgeorge/backrest/blob/main/internal/orchestrator/tasks/taskbackup.go#L137-L141

This is because the tasks are immediately returning when a hook returns an error, it's probably the case that the same error handling flow as used when the restic command fails should also apply to hook failures when a task is triggering a hook that isn't an error hook.

Broadly I think the rule that backrest should try to be consistent about is

• error hooks do not trigger other hooks on error.
• non-error hooks will trigger error handlers for the current task type