Skip to content

restic check doesn't show progress on large repos #749

Open
@patrickwolf

Description

@patrickwolf

Describe the bug
Backup and restore show progress in Backrest. But check does not and on a big repo it can take 8+ hours to run.

To Reproduce
Click on check on your repo

Expected behavior
See progress like backup and restore show

Platform Info

  • Any platform
  • Backrest Version v.0.18

Additional context
I imagine it's here that it would need to be adjusted but really don't know the code well enough to make a PR

func (r *Repo) ForgetSnapshot(ctx context.Context, snapshotId string, opts ...GenericOption) error {
args := []string{"forget", "--json", snapshotId}
_, err := r.executeWithOutput(ctx, args, opts...)
return err
}
func (r *Repo) Prune(ctx context.Context, pruneOutput io.Writer, opts ...GenericOption) error {
return r.runSimpleCommand(ctx, []string{"prune"}, pruneOutput, opts...)
}
func (r *Repo) Check(ctx context.Context, checkOutput io.Writer, opts ...GenericOption) error {
cmd := r.commandWithContext(ctx, []string{"check"}, opts...)
if checkOutput != nil {
r.pipeCmdOutputToWriter(cmd, checkOutput)
}
if err := cmd.Run(); err != nil {
return newCmdError(ctx, cmd, err)
}
return nil
}

And thanks for backrest. I'm loving it!!

Screenshots
Image

Image

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions