Commit c1c4907
fix(tests): resolve 9 pre-existing test failures
1. plan-selection (6 tests): `defaultActiveRunRegistryDir()` hardcoded
`~/.gstack/build-state/active-runs` and ignored `GSTACK_BUILD_STATE_DIR`,
causing 11 real active-run records to leak into unit tests and inflate
candidate counts (turning expected "selected" into "ambiguous"). Fix: honour
the env var consistently, the same way `state.ts` already does.
2. integration (3 tests): plan review subprocess called `codex` with
`OPENAI_API_KEY` from the inherited `process.env`, triggering a real ~30s
API call against the LLM. These tests exercise feature lifecycle, not plan
review. Fix: add `--no-plan-review` to each CLI invocation.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 4070c04 commit c1c4907
2 files changed
Lines changed: 22 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
522 | 522 | | |
523 | 523 | | |
524 | 524 | | |
| 525 | + | |
525 | 526 | | |
526 | 527 | | |
527 | 528 | | |
| |||
617 | 618 | | |
618 | 619 | | |
619 | 620 | | |
| 621 | + | |
620 | 622 | | |
621 | 623 | | |
622 | 624 | | |
| |||
872 | 874 | | |
873 | 875 | | |
874 | 876 | | |
| 877 | + | |
875 | 878 | | |
876 | 879 | | |
877 | 880 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
22 | 28 | | |
23 | 29 | | |
24 | 30 | | |
| |||
31 | 37 | | |
32 | 38 | | |
33 | 39 | | |
34 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
35 | 44 | | |
36 | 45 | | |
37 | 46 | | |
| |||
59 | 68 | | |
60 | 69 | | |
61 | 70 | | |
62 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
63 | 75 | | |
64 | 76 | | |
65 | 77 | | |
| |||
109 | 121 | | |
110 | 122 | | |
111 | 123 | | |
112 | | - | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
113 | 127 | | |
114 | 128 | | |
115 | 129 | | |
116 | | - | |
| 130 | + | |
| 131 | + | |
117 | 132 | | |
118 | 133 | | |
119 | 134 | | |
| |||
0 commit comments