Skip to content

2024.3 breaking changes #43

@nmggithub

Description

@nmggithub

Describe the bug:
Building fails with

{path-to}/intellij-ghidra/src/main/kotlin/com/codingmates/ghidra/intellij/ide/facet/GhidraFacetConfigurationEditor.kt:52:17 Using 'textFieldWithBrowseButton(String? = ..., Project? = ..., FileChooserDescriptor = ..., ((chosenFile: VirtualFile) -> String)? = ...): Cell<TextFieldWithBrowseButton>' is an error. Use [Row.textFieldWithBrowseButton(String, Project?, ((VirtualFile) -> String)?)] or [Row.textFieldWithBrowseButton(FileChooserDescriptor, Project?, ((VirtualFile) -> String)?)] together with [FileChooserDescriptor.withTitle]

Steps to reproduce:
Attempt to build.

Expected behavior:
The build succeeds.

Additional context:
JetBrains/intellij-community@a5666ab#diff-80d98b7ed1bbfc2c7a89baa43766551f155d828a0b884a5e052ba4620d2fe3d1R350-R355

This usage of textFieldWithBrowseButton was deprecated.

                textFieldWithBrowseButton(title, context.project, fileChooserDescriptor)

It should be replaced with

                textFieldWithBrowseButton(fileChooserDescriptor.withTitle(title), context.project)

For 2024.3 builds.

Note that this will fail against earlier versions as this new usage was also made is 2024.3. It's unclear to me if there is another way to do this while still retaining the title usage, but the above is the quick-and-dirty way.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions