Fix for downloaded RetroAchievements content (#127)

Author: michael-j-green

hasheous/Classes/Metadata/RetroAchievements/MetadataDownload.cs

@@ -181,7 +181,12 @@ public void Download()
                 if (datFile.allowOverwrite == true)
                 {
                     // copy the DAT file to the signature ingest directory
-                    File.Copy(datFile.FileName, Path.Combine(Config.LibraryConfiguration.LibrarySignaturesDirectory, "RetroAchievements", Path.GetFileName(datFile.FileName)));
+                    string ingestPath = Path.Combine(Config.LibraryConfiguration.LibrarySignaturesDirectory, "RetroAchievements", Path.GetFileName(datFile.FileName));
+                    if (File.Exists(ingestPath))
+                    {
+                        File.Delete(ingestPath);
+                    }
+                    File.Copy(datFile.FileName, ingestPath);
                 }
             }
 

hasheous/Classes/Metadata/TheGamesDB/SQL/MetadataDownload.cs

@@ -94,6 +94,10 @@ public string Download()
                 string sqlFile = Directory.GetFiles(extractedFolder, "*.sql", SearchOption.AllDirectories).FirstOrDefault();
 
                 // move the sql file to the correct location
+                if (File.Exists(LocalFileName))
+                {
+                    File.Delete(LocalFileName);
+                }
                 File.Move(sqlFile, LocalFileName);
 
                 // reset the last modified date

hasheous/Classes/SignatureIngestors/XML.cs

@@ -448,10 +448,20 @@ public void Import(string SearchPath, string ProcessedDirectory, gaseous_signatu
                             }
                         }
 
-                        File.Move(XMLFile, Path.Combine(ProcessedDirectory, Path.GetFileName(XMLFile)));
+                        string destFile = Path.Combine(ProcessedDirectory, Path.GetFileName(XMLFile));
+                        if (File.Exists(destFile))
+                        {
+                            File.Delete(destFile);
+                        }
+                        File.Move(XMLFile, destFile);
                         if (DBFile != null)
                         {
-                            File.Move(DBFile, Path.Combine(XMLDBProcessedDirectory, Path.GetFileName(DBFile)));
+                            string destDBFile = Path.Combine(XMLDBProcessedDirectory, Path.GetFileName(DBFile));
+                            if (File.Exists(destDBFile))
+                            {
+                                File.Delete(destDBFile);
+                            }
+                            File.Move(DBFile, destDBFile);
                         }
                     }
                     catch (Exception ex)
@@ -462,7 +472,12 @@ public void Import(string SearchPath, string ProcessedDirectory, gaseous_signatu
                 else
                 {
                     Logging.Log(Logging.LogType.Information, "Signature Ingest", "Rejecting already imported " + XMLType.ToString() + " file: " + XMLFile);
-                    File.Move(XMLFile, Path.Combine(ProcessedDirectory, Path.GetFileName(XMLFile)));
+                    string destFile = Path.Combine(ProcessedDirectory, Path.GetFileName(XMLFile));
+                    if (File.Exists(destFile))
+                    {
+                        File.Delete(destFile);
+                    }
+                    File.Move(XMLFile, destFile);
                     if (DBFile != null)
                     {
                         File.Move(DBFile, Path.Combine(XMLDBProcessedDirectory, Path.GetFileName(DBFile)));