fix: harden bdstore ready filtering and conformance setup

Author: julianknutsen

internal/beads/bdstore.go

@@ -738,9 +738,13 @@ func (s *BdStore) Ready() ([]Bead, error) {
 		return nil, fmt.Errorf("bd ready: %w", err)
 	}
 	issues := parseIssuesTolerant(extractJSON(out))
-	result := make([]Bead, len(issues))
+	result := make([]Bead, 0, len(issues))
 	for i := range issues {
-		result[i] = issues[i].toBead()
+		bead := issues[i].toBead()
+		if IsReadyExcludedType(bead.Type) {
+			continue
+		}
+		result = append(result, bead)
 	}
 	return result, nil
 }

internal/beads/bdstore_test.go

@@ -518,6 +518,31 @@ func TestBdStoreReady(t *testing.T) {
 	}
 }
 
+func TestBdStoreReadyFiltersInfraTypes(t *testing.T) {
+	runner := fakeRunner(map[string]struct {
+		out []byte
+		err error
+	}{
+		`bd ready --json --limit 0`: {
+			out: []byte(`[
+				{"id":"bd-task","title":"ready one","status":"open","issue_type":"task","created_at":"2025-01-15T10:30:00Z"},
+				{"id":"bd-session","title":"infra session","status":"open","issue_type":"session","created_at":"2025-01-15T10:31:00Z"}
+			]`),
+		},
+	})
+	s := beads.NewBdStore("/city", runner)
+	got, err := s.Ready()
+	if err != nil {
+		t.Fatal(err)
+	}
+	if len(got) != 1 {
+		t.Fatalf("Ready() returned %d beads, want 1", len(got))
+	}
+	if got[0].ID != "bd-task" {
+		t.Fatalf("Ready()[0].ID = %q, want %q", got[0].ID, "bd-task")
+	}
+}
+
 func TestBdStoreReadyEmpty(t *testing.T) {
 	runner := fakeRunner(map[string]struct {
 		out []byte

test/integration/bdstore_test.go

@@ -18,6 +18,7 @@ import (
 	"github.com/gastownhall/gascity/internal/beads"
 	"github.com/gastownhall/gascity/internal/beads/beadstest"
 	"github.com/gastownhall/gascity/internal/doctor"
+	"gopkg.in/yaml.v3"
 )
 
 const (
@@ -74,17 +75,7 @@ func TestBdStoreConformance(t *testing.T) {
 
 		runBDInit(t, wsDir, prefix, serverPort)
 
-		// Explicitly set issue_prefix (required for bd create).
-		bdConfig := exec.Command("bd", "config", "set", "issue_prefix", prefix)
-		bdConfig.Dir = wsDir
-		if out, err := bdConfig.CombinedOutput(); err != nil {
-			t.Fatalf("bd config set: %v: %s", err, out)
-		}
-		customTypes := exec.Command("bd", "config", "set", "types.custom", strings.Join(doctor.RequiredCustomTypes, ","))
-		customTypes.Dir = wsDir
-		if out, err := customTypes.CombinedOutput(); err != nil {
-			t.Fatalf("bd config set types.custom: %v: %s", err, out)
-		}
+		writeCustomTypesConfig(t, wsDir, doctor.RequiredCustomTypes)
 
 		return beads.NewBdStore(wsDir, beads.ExecCommandRunner())
 	}
@@ -176,6 +167,38 @@ func runBDInit(t *testing.T, dir, prefix, port string) {
 	}
 }
 
+func writeCustomTypesConfig(t *testing.T, wsDir string, customTypes []string) {
+	t.Helper()
+
+	configPath := filepath.Join(wsDir, ".beads", "config.yaml")
+	data, err := os.ReadFile(configPath)
+	if err != nil {
+		t.Fatalf("reading config.yaml: %v", err)
+	}
+
+	cfg := map[string]any{}
+	if len(data) > 0 {
+		if err := yaml.Unmarshal(data, &cfg); err != nil {
+			t.Fatalf("parsing config.yaml: %v", err)
+		}
+	}
+
+	typesCfg, ok := cfg["types"].(map[string]any)
+	if !ok || typesCfg == nil {
+		typesCfg = map[string]any{}
+	}
+	typesCfg["custom"] = strings.Join(customTypes, ",")
+	cfg["types"] = typesCfg
+
+	out, err := yaml.Marshal(cfg)
+	if err != nil {
+		t.Fatalf("marshaling config.yaml: %v", err)
+	}
+	if err := os.WriteFile(configPath, out, 0o644); err != nil {
+		t.Fatalf("writing config.yaml: %v", err)
+	}
+}
+
 // ensureDoltIdentity ensures dolt has user.name and user.email set.
 // Copies from git config if available, otherwise sets defaults.
 func ensureDoltIdentity(t *testing.T) {